New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDN-4182: Script cleanup + track ovnk upstream issues in jira #97
SDN-4182: Script cleanup + track ovnk upstream issues in jira #97
Conversation
fa909d3
to
0d4fb52
Compare
Our bugs are not on bugzilla anymore, let's remove bugzilla queries from the script. Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
ab6325f
to
8f52623
Compare
/assign @flavio-fernandes |
@ricky-rav: This pull request references SDN-4182 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@ricky-rav: This pull request references SDN-4182 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I have a few comments
And an ask: lint it using black:
cd network-tools.git/jira-scripts
python3 -m venv --copies .env && source ./.env/bin/activate
pip install --upgrade pip
pip install black
black network_bugs_overview
deactivate
@@ -7,11 +7,9 @@ import sys | |||
from tabulate import tabulate | |||
import time | |||
|
|||
import bugzilla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bye bye bz!
Please remove the references to Bugzilla from the readme as well:
https://github.com/openshift/network-tools/blob/master/jira-scripts/README.md
jira-scripts/network_bugs_overview
Outdated
@@ -112,6 +133,117 @@ def init_developers_dict(): | |||
return developers | |||
|
|||
|
|||
def retrieve_open_github_issues(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
We're not using it anymore when calculating the workload of each team member. Let's remove it. Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Also, make sure "-q" retrieves jira bugs (quick option). Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Ovn-kubernetes upstream issues labeled with "ci-flake" are not tracked in JIRA: let's create a jira user story under the SDN-4175 epic for each such open issue: - the assignee is kept whenever possible, otherwise bbennett is used. - the summary (title) of these jira cards will start with upstream-$GITHUB_ISSUE_ID, where $GITHUB_ISSUE_ID is the ID found in the URL of the issue itself (e.g. upstream-3986 for ovn-org/ovn-kubernetes#3986) A list of which jira stories have been created is printed to stdout, as well as a list of stories in the SDN-4175 epic whose status doesn't match the status of the github issue they're tracking. The new "-g" ("--process-github-issues") input parameter executes this new functionality, or the script alone without any input parameters. Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
8f52623
to
5667a5c
Compare
Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
@flavio-fernandes I addressed your comments and I also overcomplicated my life by printing out all github issues and jira stories that are not in sync with each other. :-D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, @ricky-rav !!!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flavio-fernandes, ricky-rav The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ricky-rav: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-network-tools-container-v4.15.0-202311152309.p0.g110f4f0.assembly.stream for distgit ose-network-tools. |
A long-due cleanup of our script and a new functionality to create jira stories for each ovnk upstream issue labeld with
ci-flake
.To sum up the relevant input parameters:
./network_bugs_overview -g
retrieves ovnk upstream issues and tracks them inside the SDN-4175 epic; assignees are kept whenever possible. For instance:./network_bugs_overview -q
prints a quick version of the team bug load, skipping the "assigned <=21 days" column, which often takes a long time./network_bugs_overview -n
prints out new bugs in markdown format./network_bugs_overview
runs: