Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-36170: MultiNetworkPolicy list and details page #15

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

upalatucci
Copy link

@upalatucci upalatucci commented Mar 19, 2024

Screenshot from 2024-03-19 15-42-22
Screenshot from 2024-03-19 15-42-17

image

Copy link

openshift-ci bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2024
id: 'multinetworkpolicy',
kind: 'MultiNetworkPolicy',
label: 'multi-networkpolicy',
// t('multi-networkpolicy')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we really need it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean the translation?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

};

export const trimLastHistoryPath = (pathName: Location['pathname']): string => {
return pathName.endsWith('checkups') ? pathName : pathName.replace(/\/[^\/]*$/, '');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkups ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't really use this function. Deleted.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function for refresh, to stay in same tab, check kif its working without it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes works on refresh

@upalatucci upalatucci changed the title MultiNetworkPolicy list MultiNetworkPolicy list and details page Mar 19, 2024
Copy link

openshift-ci bot commented Mar 19, 2024

@upalatucci: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@metalice metalice added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
@metalice metalice changed the title MultiNetworkPolicy list and details page CNV-36170: MultiNetworkPolicy list and details page Mar 20, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2024

@upalatucci: This pull request references CNV-36170 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Screenshot from 2024-03-19 15-42-22
Screenshot from 2024-03-19 15-42-17

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@metalice
Copy link

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2024

@metalice: This pull request references CNV-36170 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 71cfbe8 into openshift:main Mar 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants