CNV-36170: Multi create form #16
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
upalatucci
force-pushed
the
multi-create-form
branch
4 times, most recently
from
b46e0bf
to
4ce54dd
Compare
upalatucci
force-pushed
the
multi-create-form
branch
2 times, most recently
from
4a11aa0
to
c89af52
Compare
|
@upalatucci: This pull request references CNV-36170 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
/jira refresh |
|
@upalatucci: This pull request references CNV-36170 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
src/utils/components/SelectMultiTypeahead/SelectMultiTypeahead.tsx
Outdated
Show resolved
Hide resolved
upalatucci
force-pushed
the
multi-create-form
branch
from
c89af52
to
3009111
Compare
upalatucci
force-pushed
the
multi-create-form
branch
2 times, most recently
from
7f3a11e
to
70d0f06
Compare
upalatucci
force-pushed
the
multi-create-form
branch
from
70d0f06
to
2dd8dd1
Compare
|
@upalatucci: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
The annotation syntax is explainer right here: https://docs.openshift.com/container-platform/4.15/networking/multiple_networks/configuring-multi-network-policy.html#nw-multi-network-policy-differences_configuring-multi-network-policy
Most of the cases would be just one nad. But in case the user wants multiple nads, the names should have
,between them.In case the nad is from another namespace we have to write
<namespace>/<name>but backend suggested to put everytime the namespace so no one will be confused