Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-36170: Multi enable button #26

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

upalatucci
Copy link

@upalatucci upalatucci commented Mar 27, 2024

MultiNetworkPolicies can be disabled by configuration.

Show the enable page in this case. Disable the button if the user has no permissions.

The page is on /networking.k8s.io~v1~NetworkPolicy/enable-multi as all pages under k8s.cni.cncf.io~v1beta1~MultiNetworkPolicy are disabled by the console because the resource does not exist yet.

Screenshot from 2024-03-27 12-27-40

In case the user does not have permissions:
Screenshot from 2024-03-27 12-27-21

Screenshot from 2024-03-27 12-27-18

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@upalatucci upalatucci changed the title Multi enable button CNV-36170: Multi enable button Mar 27, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2024

@upalatucci: This pull request references CNV-36170 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

MultiNetworkPolicies can be disabled by configuration.

Show the enable page in this case. Disable the button if the user has no permissions.

The page is on /networking.k8s.io~v1~NetworkPolicy/enable-multi as all pages under k8s.cni.cncf.io~v1beta1~MultiNetworkPolicy is disabled by the console as the resource does not exist yet.

Screenshot from 2024-03-27 12-27-40
Screenshot from 2024-03-27 12-27-21
Screenshot from 2024-03-27 12-27-18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2024

@upalatucci: This pull request references CNV-36170 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

MultiNetworkPolicies can be disabled by configuration.

Show the enable page in this case. Disable the button if the user has no permissions.

The page is on /networking.k8s.io~v1~NetworkPolicy/enable-multi as all pages under k8s.cni.cncf.io~v1beta1~MultiNetworkPolicy are disabled by the console because the resource does not exist yet.

Screenshot from 2024-03-27 12-27-40
Screenshot from 2024-03-27 12-27-21
Screenshot from 2024-03-27 12-27-18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2024

@upalatucci: This pull request references CNV-36170 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

MultiNetworkPolicies can be disabled by configuration.

Show the enable page in this case. Disable the button if the user has no permissions.

The page is on /networking.k8s.io~v1~NetworkPolicy/enable-multi as all pages under k8s.cni.cncf.io~v1beta1~MultiNetworkPolicy are disabled by the console because the resource does not exist yet.

Screenshot from 2024-03-27 12-27-40

In case the user does not have permissions:
Screenshot from 2024-03-27 12-27-21

Screenshot from 2024-03-27 12-27-18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@avivtur avivtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)
Added some comments

src/utils/models/index.ts Outdated Show resolved Hide resolved
src/utils/models/index.ts Outdated Show resolved Hide resolved
src/views/networkpolicies/list/hooks/useIsMultiEnabled.tsx Outdated Show resolved Hide resolved
src/views/networkpolicies/list/EnableMultiPage.tsx Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
Copy link

openshift-ci bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Mar 28, 2024

@upalatucci: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b555c63 into openshift:main Mar 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants