nob run controller: brushing #109
Conversation
openshift-ci
bot
added
the
approved
alebedev87
force-pushed
the
nob-run-controller-brushing
branch
2 times, most recently
from
d9e90a6
to
cad8a0c
Compare
| @@ -14,6 +14,7 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" | |||
|
|
|||
| v1alpha2 "github.com/openshift/node-observability-operator/api/v1alpha2" | |||
| opctrl "github.com/openshift/node-observability-operator/pkg/operator/controller" | |||
There was a problem hiding this comment.
I think we can keep the same name for the controller (or any other package) wherever we are importing it, just for easy readability.
There was a problem hiding this comment.
From what I can see it's opctrl everywhere:
$ agi 'github.com/openshift/node-observability-operator/pkg/operator/controller\"'
pkg/operator/controller/nodeobservability/daemonset.go
17: opctrl "github.com/openshift/node-observability-operator/pkg/operator/controller"
pkg/operator/controller/nodeobservability/service.go
20: opctrl "github.com/openshift/node-observability-operator/pkg/operator/controller"
pkg/operator/controller/nodeobservabilityrun/controller.go
47: opctrl "github.com/openshift/node-observability-operator/pkg/operator/controller"
There was a problem hiding this comment.
Yes, because I also used opctrl in my PR after seeing this.
|
/retest |
| - typecheck | ||
| - unused | ||
| - varcheck |
There was a problem hiding this comment.
That's a much needed change for the clean make verify
There was a problem hiding this comment.
Unfortunately the support for it was dropped, so golangci-lint of version 1.50.0 (latest of the moment) prints a warning about it.
alebedev87
force-pushed
the
nob-run-controller-brushing
branch
from
cad8a0c
to
8f8da35
Compare
|
/lgtm |
openshift-merge-robot
added
the
needs-rebase
alebedev87
force-pushed
the
nob-run-controller-brushing
branch
from
8f8da35
to
0d14ccc
Compare
openshift-merge-robot
removed
the
needs-rebase
|
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87, sherine-k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/label docs-approved |
openshift-ci
bot
added
the
docs-approved
|
/label px-approved As per Chris Fields, the docs are sufficient for this release. |
openshift-ci
bot
added
the
px-approved
No description provided.