Rely on update events for MCP checks instead of polling #60
Conversation
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| // status update which need not be queued for reconciliation | ||
| if _, ok := e.ObjectOld.(*v1alpha1.NodeObservabilityMachineConfig); ok { | ||
| return e.ObjectOld.GetGeneration() != e.ObjectNew.GetGeneration() | ||
| } |
There was a problem hiding this comment.
In comment you mention ResourceVersion, but code compares Generation
There was a problem hiding this comment.
comment incorporated
There was a problem hiding this comment.
This is good change, thanks!
Co-authored-by: Josef Karasek <karasek.jose@gmail.com>
| Owns(&mcv1.MachineConfig{}). | ||
| Owns(&mcv1.MachineConfigPool{}). | ||
| WithEventFilter(ignoreNOMCStatusUpdates()). |
There was a problem hiding this comment.
You can remove this line now.
There was a problem hiding this comment.
incorporated comment
|
@bharath-b-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bharath-b-rh, josefkarasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label tide/merge-method-squash |
openshift-ci
bot
added
tide/merge-method-squash
No description provided.