Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add negative UTs for NOMC #63

Merged
merged 12 commits into from
Jun 14, 2022
Merged

Add negative UTs for NOMC #63

merged 12 commits into from
Jun 14, 2022

Conversation

bharath-b-rh
Copy link
Contributor

@bharath-b-rh bharath-b-rh commented Jun 7, 2022 •
edited
Loading

ok github.com/openshift/node-observability-operator/pkg/operator/controller/machineconfig 4.525s coverage: 92.5% of statements
? github.com/openshift/node-observability-operator/pkg/operator/controller/machineconfig/machineconfigfakes [no test files]

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bharath-b-rh
Copy link
Contributor Author

/assign @bharath-b-rh

@bharath-b-rh bharath-b-rh marked this pull request as ready for review June 7, 2022 12:13
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2022
@openshift-ci openshift-ci bot requested a review from alebedev87 June 7, 2022 12:13
@ayesha54
Copy link
Contributor

ayesha54 commented Jun 7, 2022

@saschagrunert

saschagrunert
saschagrunert approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2022
@ayesha54
Copy link
Contributor

ayesha54 commented Jun 8, 2022

/lgtm

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2022
@bharath-b-rh
Copy link
Contributor Author

/test e2e-gcp

@lmzuccarelli
Copy link
Contributor

@bharath-b-rh - this is really a great effort. Great work Bharat

@lmzuccarelli
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2022
@sherine-k
Copy link
Contributor

/approve

@lmzuccarelli
Copy link
Contributor

/label qe-approved
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jun 9, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh, saschagrunert, sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD f89e419 and 8 for PR HEAD 92f4965 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD f89e419 and 7 for PR HEAD 92f4965 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f89e419 and 6 for PR HEAD 92f4965 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD e938f8b and 5 for PR HEAD 92f4965 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD e938f8b and 4 for PR HEAD 92f4965 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2022
@sherine-k
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD ef9a127 and 8 for PR HEAD 3226cff in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2022
@lmzuccarelli
Copy link
Contributor

lmzuccarelli commented Jun 14, 2022 •
edited
Loading

Looks like there is a unit test failure (logger_init)

--- FAIL: TestReconcileClientFakes/logger_init_failure (0.00s)
       controller_test.go:1380: Reconcile() err: <nil>, wantErr: true

@lmzuccarelli
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 14, 2022

@bharath-b-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit c2757b1 into openshift:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@arjunrn arjunrn Awaiting requested review from arjunrn

@lmzuccarelli lmzuccarelli Awaiting requested review from lmzuccarelli

@alebedev87 alebedev87 Awaiting requested review from alebedev87

Assignees

@saschagrunert saschagrunert

@ayesha54 ayesha54

@sherine-k sherine-k

@lmzuccarelli lmzuccarelli

@bharath-b-rh bharath-b-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bharath-b-rh @ayesha54 @lmzuccarelli @sherine-k @openshift-ci-robot @saschagrunert