Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-14274: Upgrade golang.org/x/net to v0.10.0 to fix the CVE #127

Merged
merged 1 commit into from Aug 11, 2023

Conversation

machine424
Copy link

The upstream node_exporter starts using golang.org/x/net@v0.10.0 starting with version v1.6.0

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 30, 2023
@openshift-ci-robot
Copy link

@machine424: This pull request references Jira Issue OCPBUGS-12507, which is invalid:

  • expected the bug to target the "4.13.z" version, but it targets "4.13.0" instead
  • expected Jira Issue OCPBUGS-12507 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The upstream node_exporter starts using golang.org/x/net@v0.10.0 starting with version v1.6.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@machine424
Copy link
Author

/jira refresh

@machine424 machine424 changed the title OCPBUGS-12507: Upgrade golang.org/x/net to v0.10.0 to fix the CVE XXX: Upgrade golang.org/x/net to v0.10.0 to fix the CVE May 30, 2023
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 30, 2023
@machine424
Copy link
Author

/jira cherrypick OCPBUGS-12507

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 30, 2023
@openshift-ci-robot
Copy link

@machine424: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

The upstream node_exporter starts using golang.org/x/net@v0.10.0 starting with version v1.6.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@machine424: Jira Issue OCPBUGS-12507 has been cloned as Jira Issue OCPBUGS-14274. Will retitle bug to link to clone.
/retitle OCPBUGS-14274: XXX: Upgrade golang.org/x/net to v0.10.0 to fix the CVE

In response to this:

/jira cherrypick OCPBUGS-12507

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title XXX: Upgrade golang.org/x/net to v0.10.0 to fix the CVE OCPBUGS-14274: XXX: Upgrade golang.org/x/net to v0.10.0 to fix the CVE May 30, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 30, 2023
@openshift-ci-robot
Copy link

@machine424: This pull request references Jira Issue OCPBUGS-14274, which is invalid:

  • expected dependent Jira Issue OCPBUGS-12507 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The upstream node_exporter starts using golang.org/x/net@v0.10.0 starting with version v1.6.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@machine424 machine424 changed the title OCPBUGS-14274: XXX: Upgrade golang.org/x/net to v0.10.0 to fix the CVE OCPBUGS-14274: Upgrade golang.org/x/net to v0.10.0 to fix the CVE May 30, 2023
The upstream node_exporter starts using golang.org/x/net@v0.10.0 starting with version v1.6.0

Signed-off-by: machine424 <ayoubmrini424@gmail.com>
@machine424
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@machine424: This pull request references Jira Issue OCPBUGS-14274, which is invalid:

  • expected dependent Jira Issue OCPBUGS-12507 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier
Copy link

/label backport-risk-assessed
/lgtm
/restest-required

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 8, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2023
@machine424
Copy link
Author

/restest-required

@simonpasquier
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 21, 2023
@openshift-ci-robot
Copy link

@simonpasquier: This pull request references Jira Issue OCPBUGS-14274, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-12507 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-12507 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from juzhao June 21, 2023 08:34
@simonpasquier
Copy link

/restest-required

2 similar comments
@machine424
Copy link
Author

/restest-required

@simonpasquier
Copy link

/restest-required

@juzhao
Copy link

juzhao commented Aug 11, 2023

/retest-required

@juzhao
Copy link

juzhao commented Aug 11, 2023

/cc @Tai-RedHat please help to test and add cherry-pick-approved and qe-approved label if no issue

@openshift-ci openshift-ci bot requested a review from Tai-RedHat August 11, 2023 03:20
@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2023

@juzhao: GitHub didn't allow me to request PR reviews from the following users: no, to, test, label, please, and, add, if, issue.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Tai-RedHat please help to test and add cherry-pick-approved and qe-approved label if no issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2023

@machine424: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Tai-RedHat
Copy link

test PR with cluster bot, no other regression issues.
/label cherry-pick-approved
/label qe-approved

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Aug 11, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5409afd into openshift:release-4.13 Aug 11, 2023
7 checks passed
@openshift-ci-robot
Copy link

@machine424: Jira Issue OCPBUGS-14274: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14274 has been moved to the MODIFIED state.

In response to this:

The upstream node_exporter starts using golang.org/x/net@v0.10.0 starting with version v1.6.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants