default moverSecurityContext to true for datamover (#1017)

Co-authored-by: Emily McMullan <emcmulla@redhat.com>
openshift · May 18, 2023 · 065eb20 · 065eb20
1 parent d00755c
commit 065eb20
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/api/v1alpha1/oadp_types.go b/api/v1alpha1/oadp_types.go
@@ -255,7 +255,7 @@ type VolumeOptions struct {
 	//+optional
 	CacheAccessMode string `json:"cacheAccessMode,omitempty"`
 	// moverSecurityContext allows enabling the PodSecurityContext used in
-	// the application pod(s)
+	// the application pod(s); default value is true
 	//+optional
 	MoverSecurityContext *bool `json:"moverSecurityContext,omitempty"`
 }

diff --git a/controllers/datamover.go b/controllers/datamover.go
@@ -770,6 +770,10 @@ func (r *DPAReconciler) buildDataMoverConfigMap(dpa *oadpv1alpha1.DataProtection
 		}
 		if sourceOptions.MoverSecurityContext != nil {
 			cmMap["SourceMoverSecurityContext"] = strconv.FormatBool(*sourceOptions.MoverSecurityContext)
+
+			// default to true
+		} else {
+			cmMap["SourceMoverSecurityContext"] = "true"
 		}
 	}
 
@@ -799,6 +803,10 @@ func (r *DPAReconciler) buildDataMoverConfigMap(dpa *oadpv1alpha1.DataProtection
 
 		if destinationOptions.MoverSecurityContext != nil {
 			cmMap["DestinationMoverSecurityContext"] = strconv.FormatBool(*destinationOptions.MoverSecurityContext)
+
+			// default to true
+		} else {
+			cmMap["DestinationMoverSecurityContext"] = "true"
 		}
 	}