Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-148 First attempt at speeding up must-gather. #1002

Merged
merged 2 commits into from May 16, 2023

Conversation

mrnold
Copy link
Contributor

@mrnold mrnold commented May 4, 2023

Attempt to speed up must-gather by removing the "oc exec" velero commands in favor of a newly-included local copy of the velero binary (introducted in #994.)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 4, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mrnold mrnold marked this pull request as ready for review May 4, 2023 18:10
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2023
log_command "Storage classes" "oc get storageclass --all-namespaces --insecure-skip-tls-verify=${skip_tls}"

# DataProtectionApplications
dpas=$(oc get dpa --all-namespaces --insecure-skip-tls-verify=${skip_tls} -o jsonpath='{range .items[*]}{.metadata.name}{" "}{.metadata.namespace}')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/jsonpath='{range .items[*]}{.metadata.name}{" "}{.metadata.namespace}')/yaml/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh.. I see you did it below.. nevermind

This comment was marked as outdated.

log_deployment "Velero" "velero"

# Storage classes
log_command "Storage classes" "oc get storageclass --all-namespaces --insecure-skip-tls-verify=${skip_tls}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to change to -o yaml

@mrnold
Copy link
Contributor Author

mrnold commented May 5, 2023

I rebased this onto master instead of the branch I was using for #994, since it was causing unneccessary confusion. This should not be merged without #994 going in first.

@mrnold mrnold marked this pull request as draft May 8, 2023 13:12
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2023
Signed-off-by: Matthew Arnold <marnold@redhat.com>
Fill out git commit in velero client version, fix DPA version gathering,
and fix a mkdir problem in log backup.

Signed-off-by: Matthew Arnold <marnold@redhat.com>
@mrnold mrnold marked this pull request as ready for review May 10, 2023 20:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2023
@mrnold
Copy link
Contributor Author

mrnold commented May 11, 2023

/retest

@mrnold
Copy link
Contributor Author

mrnold commented May 11, 2023

/test 4.11-operator-e2e-gcp

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrnold, shubham-pampattiwar, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [shubham-pampattiwar,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2023

@mrnold: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shubham-pampattiwar shubham-pampattiwar merged commit ecc31f0 into openshift:master May 16, 2023
11 of 12 checks passed
@shubham-pampattiwar
Copy link
Member

/cherry-pick oadp-1.2

@openshift-cherrypick-robot
Copy link
Contributor

@shubham-pampattiwar: cannot checkout oadp-1.2: error checking out oadp-1.2: exit status 1. output: error: pathspec 'oadp-1.2' did not match any file(s) known to git

In response to this:

/cherry-pick oadp-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shubham-pampattiwar
Copy link
Member

/cherry-pick oadp-1.2

@openshift-cherrypick-robot
Copy link
Contributor

@shubham-pampattiwar: new pull request created: #1011

In response to this:

/cherry-pick oadp-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants