Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-1987: Correctly get backup/restore logs in must-gather. #1036

Merged
merged 1 commit into from May 24, 2023

Conversation

mrnold
Copy link
Contributor

@mrnold mrnold commented May 24, 2023

In must-gather's gather_logs scripts, the velero command needs a namespace to be able to find the requested backup or restore.

Without this, the velero command is not able to find individual
backups or restores when collecting logs.

Signed-off-by: Matthew Arnold <marnold@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 24, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 24, 2023

@mrnold: This pull request references OADP-1987 which is a valid jira issue.

In response to this:

In must-gather's gather_logs scripts, the velero command needs a namespace to be able to find the requested backup or restore.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eemcmullan, kaovilai, mrnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [eemcmullan,kaovilai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrnold
Copy link
Contributor Author

mrnold commented May 24, 2023

/test 4.11-operator-e2e-gcp

@openshift-ci
Copy link

openshift-ci bot commented May 24, 2023

@mrnold: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@weshayutin weshayutin merged commit 5ac8722 into openshift:oadp-1.2 May 24, 2023
13 checks passed
@mrnold
Copy link
Contributor Author

mrnold commented May 24, 2023

/cherry-pick master

@openshift-cherrypick-robot
Copy link
Contributor

@mrnold: new pull request created: #1037

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants