Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-1941: Default datamover SC and add mover annotation #1058

Merged
merged 1 commit into from Jun 3, 2023

Conversation

eemcmullan
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from kaovilai and sseago June 2, 2023 17:02
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@eemcmullan eemcmullan changed the title Default datamover SC and add mover annotation OADP-1941: Default datamover SC and add mover annotation Jun 2, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 2, 2023

@eemcmullan: This pull request references OADP-1941 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

return false, err
}

// add volsync privileged mover annotation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2023
Copy link
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data and file permissions are correct :) well done!

sh-4.4$ cd /var/lib/mysql/
sh-4.4$ ls -la
total 24
drwxrwsr-x. 4 root  mysql  4096 Jun  2 18:08 .
drwxr-xr-x. 1 root  root     53 Jun 20  2022 ..
drwxrws---. 6 mysql mysql  4096 Jun  2 18:08 data
drwxrws---. 2 root  mysql 16384 Jun  2 17:48 lost+found
srwxrwxrwx. 1 mysql mysql     0 Jun  2 18:08 mysql.sock
sh-4.4$ cat /etc/passwd | grep mysql
mysql:x:27:27:MySQL Server:/var/lib/mysql:/sbin/nologin
sh-4.4$ cat /etc/group | grep mysql
root:x:0:mysql
mysql:x:27:
sh-4.4$ 

@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eemcmullan, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [eemcmullan,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shubham-pampattiwar
Copy link
Member

Tested B/R for the todolist mysql app, worked me as well !

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD dca3914 and 2 for PR HEAD fd7036f in total

@kaovilai
Copy link
Member

kaovilai commented Jun 2, 2023

flake

"time=\"2023-06-02T20:14:59Z\" level=error msg=\"Timed out awaiting reconciliation of volumesnapshotcontent snapcontent-14546aa9-6f66-4d35-ac03-8dfc8fb7b2d1\" backup=openshift-adp/mongo-datamover-e2e-92baba90-0180-11ee-b18b-0a580a818460 cmd=/plugins/velero-plugin-for-vsm logSource=\"/opt/app-root/src/velero-plugin-for-vsm/internal/util/util.go:472\" pluginName=velero-plugin-for-vsm",

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2023

@eemcmullan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ad2f8cd into openshift:master Jun 3, 2023
13 checks passed
@weshayutin
Copy link
Contributor

/cherry-pick oadp-1.2

@openshift-cherrypick-robot
Copy link
Contributor

@weshayutin: new pull request created: #1064

In response to this:

/cherry-pick oadp-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants