Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oadp-1.2: OADP-1057: CloudStorageLocation Prefix/CACert support (#1126) #1141

Merged

Conversation

kaovilai
Copy link
Member

  • validator and type updates

  • validator and type updates

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

  • CloudStorageLocation prefix is added to BSL

  • clarify backupImages error

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

  • validator refactor returns err from validating funcs

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

  • unit tests fix

  • simplify expression

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

  • Add ignorable restore error logs and unit test

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

  • consistent error string across bl.velero and bl.cloudstorage

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

* validator and type updates

* validator and type updates

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* CloudStorageLocation prefix is added to BSL

* clarify backupImages error

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* validator refactor returns err from validating funcs

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* unit tests fix

* simplify expression

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* Add ignorable restore error logs and unit test

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* consistent error string across bl.velero and bl.cloudstorage

---------

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 28, 2023

@kaovilai: This pull request references OADP-1057 which is a valid jira issue.

In response to this:

  • validator and type updates

  • validator and type updates

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

  • CloudStorageLocation prefix is added to BSL

  • clarify backupImages error

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

  • validator refactor returns err from validating funcs

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

  • unit tests fix

  • simplify expression

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

  • Add ignorable restore error logs and unit test

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

  • consistent error string across bl.velero and bl.cloudstorage

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 28, 2023
@kaovilai
Copy link
Member Author

/cc @sseago @shubham-pampattiwar

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,shubham-pampattiwar,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaovilai
Copy link
Member Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai kaovilai merged commit bd3019e into openshift:oadp-1.2 Aug 29, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants