OADP-2747: Re-enable DataMover E2E tests #1170
Conversation
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
|
@mateusoliveira43: This pull request references OADP-2747 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but it targets "OADP 1.3.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-reference
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
| test-e2e-cleanup: login-required | ||
| $(OC_CLI) delete volumesnapshotcontent --all | ||
| $(OC_CLI) delete volumesnapshotclass oadp-example-snapclass --ignore-not-found=true | ||
| $(OC_CLI) delete backup -n $(OADP_TEST_NAMESPACE) --all |
There was a problem hiding this comment.
If I delete backup, it deletes dataupload. Should I change order or just add the ones that delete another entities here?
There was a problem hiding this comment.
I would add --wait and move all data that velero typically cleans up on backup deletion last.
| @@ -156,11 +85,8 @@ var _ = Describe("Must-gather backup restore tests", func() { | |||
| } | |||
|
|
|||
| DescribeTable("backup, restore applications, and must gather", | |||
| // TODO this function has a lot of duplications with tests/e2e/backup_restore_suite_test.go | |||
There was a problem hiding this comment.
what is the goal of this test? It seems a duplication of bacjup/restore test
There was a problem hiding this comment.
This test is a duplicate of backup/restore test but only one case is included with the addition of running must gather after the test to check expected dirs and files from must-gather exists.
if len(brCase.MustGatherFiles) > 0 && clusterDir != "" {
for _, file := range brCase.MustGatherFiles {
_, err := os.Stat(clusterDir + "/" + file)
Expect(err).ToNot(HaveOccurred())
}
}There was a problem hiding this comment.
Can we run it as separate test after that specific test?
tests/e2e/sample-applications/mysql-persistent/mysql-backup.yaml
Outdated
Show resolved
Hide resolved
|
@mateusoliveira43: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
|
/override ci/prow/4.10-operator-e2e-aws |
|
@kaovilai: Overrode contexts on behalf of kaovilai: ci/prow/4.10-operator-e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
+1 from me.. will review more soon |
|
/lgtm Thanks @mateusoliveira43 |
| @@ -19,7 +19,8 @@ var _ = Describe("Subscription Config Suite Test", func() { | |||
| err := dpaCR.Build(CSI) | |||
| Expect(err).NotTo(HaveOccurred()) | |||
| //also test restic | |||
| dpaCR.CustomResource.Spec.Configuration.Restic.Enable = pointer.BoolPtr(true) | |||
| dpaCR.CustomResource.Spec.Configuration.NodeAgent.Enable = pointer.BoolPtr(true) | |||
| dpaCR.CustomResource.Spec.Configuration.NodeAgent.UploaderType = "restic" | |||
There was a problem hiding this comment.
I'd add a case here for node-agent uploaderType kopia for another case.
There was a problem hiding this comment.
We can do, but I think it is https://issues.redhat.com/browse/OADP-2746 responsibility (here I made the change because our DPA validation does not allow new and old syntax together)
There was a problem hiding this comment.
Note that uploaderType is irrelevant for CSI snapshot/datamover cases. The config value is ignored there. It's only ever used for fsbackup volumes.
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
|
@mateusoliveira43: This pull request references OADP-2747 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but it targets "OADP 1.3.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
@mateusoliveira43: This pull request references OADP-2747 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but it targets "OADP 1.3.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mateusoliveira43, mrnold, shubham-pampattiwar, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mateusoliveira43: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Update DataMover E2E tests to run against Velero builtin DataMover.
How to test
Read Testing documentation and run
make test-e2e. Check if DataMover was invoked (DataUploadsandDataDownloadsinstances were created).