New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OADP-1.2 Cherry-pick of OADP-659: Remove HTTP/HTTPS port numbers from AWS S3 URLs. #1180
Conversation
…1169) * OADP-659 Remove port numbers if HTTP or HTTPS. Avoids a signature mismatch from S3-compatible services. Signed-off-by: Matthew Arnold <marnold@redhat.com> * OADP-659 Move StripDefaultPorts to pkg/common. Signed-off-by: Matthew Arnold <marnold@redhat.com> * OADP-659 Fix port number in comment. Signed-off-by: Matthew Arnold <marnold@redhat.com> --------- Signed-off-by: Matthew Arnold <marnold@redhat.com>
SanitizeHostForHeader puts the stripped host name into the Host field of the HTTP request, but only if it actually needed to strip the port. If there is already no port, that Host field can be blank, and there is no reason to overwrite the URL's host field. Signed-off-by: Matthew Arnold <marnold@redhat.com>
@mrnold: This pull request references OADP-659 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
/retest |
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_oadp-operator/1180/pull-ci-openshift-oadp-operator-oadp-1.2-4.12-operator-e2e-azure/1712518428683669504#1:build-log.txt%3A1180 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mrnold, shubham-pampattiwar, sseago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1.2.3 released |
@mrnold: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Cherry pick pull requests 1169 and 1177 for OADP 1.2.