OADP-3189: do not remove labels from OADP namespace #1274
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@mateusoliveira43: This pull request references OADP-3189 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mateusoliveira43: This pull request references OADP-3189 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
openshift-ci
bot
removed
the
approved
openshift-ci
bot
added
the
approved
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
mateusoliveira43
force-pushed
the
fix/do-not-remove-labels-from-namespace
branch
from
2495f47
to
29956c0
Compare
|
/cherry-pick oadp-1.3 |
|
@shubham-pampattiwar: once the present PR merges, I will cherry-pick it on top of oadp-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kaovilai please review |
|
@weshayutin I had already reviewed here waiting on changes/discussions. |
ah.. thank you @kaovilai |
There was a problem hiding this comment.
per #1274 (comment)
Requesting that we use patch to avoid update race conditions
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
openshift-ci
bot
removed
the
approved
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
|
|
||
| operatorNamespace, err := clientset.CoreV1().Namespaces().Get(context.TODO(), watchNamespaceName, metav1.GetOptions{}) |
openshift-ci
bot
added
the
approved
We are running unit tests via this image
❯ docker run --platform linux/amd64 -w $PWD -v $PWD:$PWD -it registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.20-openshift-4.14 \
sh -c "go list ./... | grep -v /tests/e2e"TL;DR, go list doesn't work currently (click to expand)``` Go compliance shim [12] [][]: Forcing GOTOOLCHAIN=local Go compliance shim [12] [][]: assessment: CGO_ENABLED=1 Go compliance shim [12] [][]: assessment: dynamic linking Go compliance shim [12] [][]: EXEMPT: 0 Go compliance shim [12] [][]: not exempt: FORCE_CGO_ENABLED="1" FORCE_DYNAMIC="1" FORCE_OPENSSL="1" FORCE_FOD_MODE="1" Go compliance shim [12] [][]: setting GOEXPERIMENT=strictfipsruntimeGo compliance shim [12] [][]: final command line arguments: "list" "./..." Go compliance shim [12] [][]: invoking real go binary Go compliance shim [12] [][]: Exited with: 1 |
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai
force-pushed
the
fix/do-not-remove-labels-from-namespace
branch
from
f6ff5c0
to
7eb4820
Compare
|
Should work now :) |
|
/retest |
1 similar comment
|
/retest |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
|
this failed datamover test only shouldn't be related |
|
@kaovilai: Overrode contexts on behalf of kaovilai: ci/prow/4.12-e2e-test-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
ran through the negative test on head.. recreated |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mateusoliveira43, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test 4.12-e2e-test-aws |
|
/override ci/prow/4.12-e2e-test-aws |
|
@kaovilai: Overrode contexts on behalf of kaovilai: ci/prow/4.12-e2e-test-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mateusoliveira43: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@shubham-pampattiwar: new pull request created: #1339 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
Instead of adding/patching PSA labels to OADP namespace, controller manager would remove all labels, and then add PSA labels to OADP namespace. This PR fixes this behavior.
How to test
From master branch and this PR branch, create a namespace and check its labels
Add some custom labels, for example
Run
OADP_TEST_NAMESPACE=<name> make deploy-olmand check the namespace's labels again. In master branch some labels should have been removed. In this PR branch, no labels should have been removed (and onlypod-security.kubernetes.io/...labels should have been modified).