Don't getProviderSecret when noDefaultBackupLocation: true, backupImages: false #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
…ages is false Use BackupImages functions when checking conditions
|
/retest |
2 similar comments
|
/retest |
|
/retest |
kaovilai
changed the title
dymurray
approved these changes
Mar 31, 2022
shubham-pampattiwar
approved these changes
Apr 8, 2022
|
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
1 task
kaovilai
added a commit
to kaovilai/oadp-operator
that referenced
this pull request
May 17, 2022
…ges: false (openshift#607) * Don't getProviderSecret when noDefaultBackupLocation flag set Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * add check that when NoDefaultBackupLocation is set, dpa.Spec.BackupImages is false Use BackupImages functions when checking conditions * fix test case
kaovilai
added a commit
that referenced
this pull request
May 18, 2022
…handling [1.0 cp] #701 #607 (#702) * OADP-524 mtc operator type Enables alternative behavior when OADP is consumed by MTC * Remove unused comment. * Don't getProviderSecret when noDefaultBackupLocation: true, backupImages: false (#607) * Don't getProviderSecret when noDefaultBackupLocation flag set Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * add check that when NoDefaultBackupLocation is set, dpa.Spec.BackupImages is false Use BackupImages functions when checking conditions * fix test case * remove duplicate test entry * test case name typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #420 OADP-460
Signed-off-by: Tiger Kaovilai tkaovila@redhat.com