Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OADP-205: Remove registry deployment in favor of plugin enhancement #743

Merged
merged 16 commits into from Jul 12, 2022
Merged

OADP-205: Remove registry deployment in favor of plugin enhancement #743

merged 16 commits into from Jul 12, 2022

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Jun 27, 2022 •
edited

This velero plugin registry enhancements will do the following

Install this PR operator with

operator-sdk run bundle quay.io/tkaovila/oadp-operator-bundle:velero-plugin-registry --namespace openshift-adp

Instruction for testing this PR prior to updated latest image at openshift/openshift-velero-plugin#145

OADP-205

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 27, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022 •
edited

Codecov Report

Merging #743 (73b52df) into master (5b41bea) will decrease coverage by 2.57%.
The diff coverage is 9.58%.

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
- Coverage   36.96%   34.39%   -2.58%     
==========================================
  Files          16       16              
  Lines        3219     2826     -393     
==========================================
- Hits         1190      972     -218     
+ Misses       1926     1763     -163     
+ Partials      103       91      -12
Impacted Files Coverage Δ
controllers/registry.go 29.23% <0.00%> (-10.97%) ⬇️
controllers/velero.go 48.28% <43.75%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 515fbb3...73b52df. Read the comment docs.

@kaovilai
Copy link
Member Author

/test all

@kaovilai
Copy link
Member Author

oops forgot needs plugin PR merge first

This was referenced Jun 28, 2022
Merged
Merged
@kaovilai kaovilai marked this pull request as ready for review June 30, 2022 14:57
@kaovilai
Copy link
Member Author

ready for review but
/hold for openshift/openshift-velero-plugin#145

@kaovilai
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 30, 2022
@openshift-ci openshift-ci bot requested a review from shawn-hurley June 30, 2022 15:10
shubham-pampattiwar
shubham-pampattiwar reviewed Jul 7, 2022
View reviewed changes
Copy link
Member

@shubham-pampattiwar shubham-pampattiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operator changes look straight forward to me, added some NITs, Thanks @kaovilai

controllers/velero.go Show resolved Hide resolved
tests/e2e/backup_restore_suite_test.go Outdated Show resolved Hide resolved
controllers/registry.go Outdated Show resolved Hide resolved
@dymurray dymurray changed the title velero-plugin-registry OADP-205: Remove registry deployment in favor of plugin enhancement Jul 7, 2022
dymurray
dymurray requested changes Jul 7, 2022
View reviewed changes
Copy link
Member

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also needs to include changes to the CSV to remove the registry as a related image.

@kaovilai
Copy link
Member Author

kaovilai commented Jul 7, 2022

Removed registry from CSV as a relatedImage.

@kaovilai
Copy link
Member Author

kaovilai commented Jul 7, 2022

updating quay bundle ...

@kaovilai
Copy link
Member Author

kaovilai commented Jul 7, 2022

bundle is up to date

@kaovilai kaovilai requested a review from dymurray July 7, 2022 18:49
@kaovilai kaovilai changed the title OADP-205: Remove registry deployment in favor of plugin enhancement OADP-205: Remove registry deployment, enable plugin registry enhancement Jul 7, 2022
@kaovilai kaovilai changed the title OADP-205: Remove registry deployment, enable plugin registry enhancement OADP-205: Remove registry deployment in favor of plugin enhancement Jul 7, 2022
@savitharaghunathan
Copy link
Member

/retest-required

@kaovilai
Copy link
Member Author

kaovilai commented Jul 8, 2022

waiting for build https://app.travis-ci.com/github/openshift/openshift-velero-plugin/builds/252993582

@kaovilai
Copy link
Member Author

kaovilai commented Jul 8, 2022

/retest

@kaovilai
Copy link
Member Author

kaovilai commented Jul 8, 2022

/test 4.9-operator-e2e-gcp

@kaovilai
Copy link
Member Author

kaovilai commented Jul 8, 2022

For AWS:
Internal 500 error

trying to reuse blob sha256:ca753d5e70afb765e08ae8e79316b2feb7618fc6c779109ac7f797709c51d9b6 at destination: failed to read from destination repository mongo-persistent/todolist-mongo-go: 500 (Internal Server Error)

For GCP
It appears GCS storage driver init function is not called...

plugin panicked: StorageDriver not registered: gcs

https://github.com/distribution/distribution/blob/3f4c558dac40dfb4fe13285ffc43a0d738d3a3f0/registry/storage/driver/gcs/gcs.go#L80
For Azure envs used was malformed.

azure: malformed storage account key: illegal base64 data at input byte 0

@kaovilai
Copy link
Member Author

openshift/openshift-velero-plugin#152 might be an issue.

@kaovilai
Copy link
Member Author

waiting on https://app.travis-ci.com/github/openshift/openshift-velero-plugin/builds/253057305 to retest again

@kaovilai
Copy link
Member Author

Looks like no retest required.. since all running tests are still installing ocp

@kaovilai
Copy link
Member Author

/test 4.10-operator-e2e-aws

dymurray
dymurray reviewed Jul 11, 2022
View reviewed changes
Copy link
Member

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, will ack when E2E is updated to disable iamge backup for GCP

@kaovilai kaovilai mentioned this pull request Jul 11, 2022
Merged
@kaovilai
Copy link
Member Author

kaovilai commented Jul 11, 2022 •
edited

GCP tests blocked by openshift/openshift-velero-plugin#155. Once travis builds plugin image, retesting GCP is expected to pass.

@kaovilai
Copy link
Member Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jul 12, 2022

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

savitharaghunathan
savitharaghunathan reviewed Jul 12, 2022
View reviewed changes
Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kaovilai
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2022
@dymurray dymurray merged commit 2665b29 into openshift:master Jul 12, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2022
@kaovilai kaovilai mentioned this pull request Jul 12, 2022
Closed
This was referenced Aug 3, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitharaghunathan savitharaghunathan savitharaghunathan left review comments

@dymurray dymurray dymurray approved these changes

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

@shubham-pampattiwar shubham-pampattiwar Awaiting requested review from shubham-pampattiwar

Assignees

@savitharaghunathan savitharaghunathan

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kaovilai @codecov-commenter @savitharaghunathan @dymurray @shubham-pampattiwar