Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-171 Adding ability for the default secrets update, to queue all DPA's #827

Closed
wants to merge 2 commits into from

Conversation

shawn-hurley
Copy link
Contributor

@shawn-hurley shawn-hurley commented Sep 19, 2022

Want to see what E2E breaks, if any before adding another test case.

OADP-171

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@shawn-hurley
Copy link
Contributor Author

/test all

controllers/dpa_controller.go Outdated Show resolved Hide resolved
controllers/dpa_controller.go Outdated Show resolved Hide resolved
controllers/dpa_controller.go Outdated Show resolved Hide resolved
controllers/dpa_controller.go Outdated Show resolved Hide resolved
controllers/dpa_controller.go Outdated Show resolved Hide resolved
controllers/dpa_controller.go Outdated Show resolved Hide resolved
@shawn-hurley
Copy link
Contributor Author

/retest

1 similar comment
@shawn-hurley
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2022
@shawn-hurley shawn-hurley marked this pull request as ready for review September 29, 2022 19:17
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Base: 31.92% // Head: 31.05% // Decreases project coverage by -0.87% ⚠️

Coverage data is based on head (1f7175d) compared to base (45fcd3d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
- Coverage   31.92%   31.05%   -0.88%     
==========================================
  Files          16       16              
  Lines        3057     3143      +86     
==========================================
  Hits          976      976              
- Misses       1989     2075      +86     
  Partials       92       92              
Impacted Files Coverage Δ
controllers/dpa_controller.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shawn-hurley
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2022

@shawn-hurley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm. Thanks @shawn-hurley

@kaovilai
Copy link
Member

kaovilai commented Oct 3, 2022

@shawn-hurley are you adding another test case?

@kaovilai kaovilai changed the title Adding ability for the default secrets update, to queue all DPA's OADP-171 Adding ability for the default secrets update, to queue all DPA's Oct 3, 2022
@shawn-hurley
Copy link
Contributor Author

I might need a hand, but I can try and get that moving. What is the time frame that we need to get this in?

@weshayutin @kaovilai

@kaovilai
Copy link
Member

@shawn-hurley moved to 1.1.2 so we have some time in the next sprint.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 16, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2023
@openshift-merge-robot
Copy link

@shawn-hurley: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2023
@openshift-ci openshift-ci bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 15, 2023
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Mar 18, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2023

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants