Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-1224: restic node-agent refactor label #879

Merged

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Jan 19, 2023

This PR fix add more changes required from #858
OADP-1224

Without this fix velero fails to discover restic, now called node-agent pods.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 19, 2023

@kaovilai: This pull request references [Jira Issue OADP-1152](https://issues.redhat.com//browse/OADP-1152), which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 19, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 19, 2023

@kaovilai: This pull request references [Jira Issue OADP-1152](https://issues.redhat.com//browse/OADP-1152), which is a valid jira issue.

In response to this:

This PR fix add more changes required from #858

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 19, 2023

@kaovilai: This pull request references [Jira Issue OADP-1152](https://issues.redhat.com//browse/OADP-1152), which is a valid jira issue.

In response to this:

This PR fix add more changes required from #858
OADP-1152

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 19, 2023

@kaovilai: This pull request references [Jira Issue OADP-1152](https://issues.redhat.com//browse/OADP-1152), which is a valid jira issue.

In response to this:

This PR fix add more changes required from #858
OADP-1152

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Base: 33.79% // Head: 33.74% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (bdb43d2) compared to base (1200dc8).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #879      +/-   ##
==========================================
- Coverage   33.79%   33.74%   -0.05%     
==========================================
  Files          17       17              
  Lines        3128     3126       -2     
==========================================
- Hits         1057     1055       -2     
  Misses       1979     1979              
  Partials       92       92              
Impacted Files Coverage Δ
controllers/restic.go 51.80% <66.66%> (-0.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kaovilai kaovilai force-pushed the oadp-1152-restic-nodeagent-labels branch from 0d35ee8 to 0676c78 Compare January 23, 2023 22:39
@kaovilai kaovilai marked this pull request as ready for review January 23, 2023 23:01
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 23, 2023

@kaovilai: This pull request references OADP-1152 which is a valid jira issue.

In response to this:

This PR fix add more changes required from #858
OADP-1152

Without this fix velero fails to discover restic, now called node-agent pods.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kaovilai kaovilai force-pushed the oadp-1152-restic-nodeagent-labels branch from 7b0806b to bb7e015 Compare January 23, 2023 23:36
@kaovilai kaovilai changed the title OADP-1152: restic node-agent refactor label OADP-1224: restic node-agent refactor label Jan 25, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 25, 2023

@kaovilai: This pull request references OADP-1224 which is a valid jira issue.

In response to this:

This PR fix add more changes required from #858
OADP-1152

Without this fix velero fails to discover restic, now called node-agent pods.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 25, 2023

@kaovilai: This pull request references OADP-1224 which is a valid jira issue.

In response to this:

This PR fix add more changes required from #858
OADP-1224

Without this fix velero fails to discover restic, now called node-agent pods.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kaovilai kaovilai force-pushed the oadp-1152-restic-nodeagent-labels branch from bdb43d2 to 0843dff Compare January 25, 2023 15:35
@kaovilai
Copy link
Member Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jan 25, 2023

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai kaovilai merged commit 3b9b40f into openshift:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants