Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-1151: Provide an option to set volsync replicationsource prune interval #896

Merged

Conversation

shubham-pampattiwar
Copy link
Member

@shubham-pampattiwar shubham-pampattiwar commented Jan 31, 2023

Related controller PR: migtools/volume-snapshot-mover#184

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2023

@shubham-pampattiwar: This pull request references OADP-1151 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2023

@shubham-pampattiwar: This pull request references OADP-1151 which is a valid jira issue.

In response to this:

Related controller PR: migtools/volume-snapshot-mover#184

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shubham-pampattiwar
Copy link
Member Author

/retest

@codecov-commenter
Copy link

Codecov Report

Base: 33.72% // Head: 33.58% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (bfcad60) compared to base (0264a37).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
- Coverage   33.72%   33.58%   -0.14%     
==========================================
  Files          17       17              
  Lines        3152     3165      +13     
==========================================
  Hits         1063     1063              
- Misses       1991     2004      +13     
  Partials       98       98              
Impacted Files Coverage Δ
controllers/datamover.go 13.76% <0.00%> (-0.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shubham-pampattiwar
Copy link
Member Author

/retest

1 similar comment
@shubham-pampattiwar
Copy link
Member Author

/retest

@shubham-pampattiwar
Copy link
Member Author

/retest

1 similar comment
@shubham-pampattiwar
Copy link
Member Author

/retest

@shubham-pampattiwar
Copy link
Member Author

/test 4.11-operator-e2e-aws

@shubham-pampattiwar
Copy link
Member Author

/retest

1 similar comment
@shubham-pampattiwar
Copy link
Member Author

/retest

@kaovilai
Copy link
Member

kaovilai commented Feb 3, 2023 via email

@shubham-pampattiwar
Copy link
Member Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 6, 2023

@shubham-pampattiwar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shubham-pampattiwar shubham-pampattiwar merged commit 110b33a into openshift:master Feb 6, 2023
@weshayutin weshayutin added customer_feature approved Indicates a PR has been approved by an approver from all required OWNERS files. custom_bell labels Feb 17, 2023
@shubham-pampattiwar shubham-pampattiwar self-assigned this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. custom_bell customer_feature jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants