oadp-1.1: OADP-1557 Add all velero server args supported to DPA

[kaovilai]

• refactor: remove reconciler from functions
• oadp-1.1: go get openshift/velero:oadp-1.1
• add server package for velero server options

change sets will be cleaned/rebased when ready for review.

Goal: support all options from velero server in oadp-1.1

Run the velero server

Usage:
  velero server [flags]

Flags:
      --backup-sync-period duration                         How often to ensure all Velero backups in object storage exist as Backup API objects in the cluster. This is the default sync period if none is explicitly specified for a backup storage location. (default 1m0s)
      --client-burst int                                    Maximum number of requests by the server to the Kubernetes API in a short period of time. (default 30)
      --client-page-size int                                Page size of requests by the server to the Kubernetes API when listing objects during a backup. Set to 0 to disable paging. (default 500)
      --client-qps float32                                  Maximum number of requests per second by the server to the Kubernetes API once the burst limit has been reached. (default 20)
      --default-backup-storage-location string              Name of the default backup storage location. DEPRECATED: this flag will be removed in v2.0. Use "velero backup-location set --default" instead. (default "default")
      --default-backup-ttl duration                         How long to wait by default before backups can be garbage collected. (default 720h0m0s)
      --default-restic-prune-frequency duration             How often 'restic prune' is run for restic repositories by default. (default 168h0m0s)
      --default-volume-snapshot-locations mapStringString   List of unique volume providers and default volume snapshot location (provider1:location-01,provider2:location-02,...)
      --default-volumes-to-restic                           Backup all volumes with restic by default.
      --disable-controllers strings                         List of controllers to disable on startup. Valid values are backup,backup-deletion,backup-sync,download-request,gc,restic-repo,restore,schedule,server-status-request
      --garbage-collection-frequency duration               How often garbage collection is run for expired backups.
  -h, --help                                                help for server
      --log-format                                          The format for log output. Valid values are text, json. (default text)
      --log-level                                           The level at which to log. Valid values are trace, debug, info, warning, error, fatal, panic. (default info)
      --metrics-address string                              The address to expose prometheus metrics (default ":8085")
      --plugin-dir string                                   Directory containing Velero plugins (default "/plugins")
      --profiler-address string                             The address to expose the pprof profiler. (default "localhost:6060")
      --restic-timeout duration                             How long backups/restores of pod volumes should be allowed to run before timing out. (default 4h0m0s)
      --restore-only                                        Run in a mode where only restores are allowed; backups, schedules, and garbage-collection are all disabled. DEPRECATED: this flag will be removed in v2.0. Use read-only backup storage locations instead.
      --restore-resource-priorities stringArray             Desired order of resource restores, the priority list contains two parts which are split by "-" element. The resources before "-" element are restored first as high priorities, the resources after "-" element are restored last as low priorities, and any resource not in the list will be restored alphabetically between the high and low priorities. (default customresourcedefinitions,namespaces,storageclasses,volumesnapshotbackups.datamover.oadp.openshift.io,volumesnapshotclass.snapshot.storage.k8s.io,volumesnapshotcontents.snapshot.storage.k8s.io,volumesnapshots.snapshot.storage.k8s.io,persistentvolumes,persistentvolumeclaims,secrets,configmaps,serviceaccounts,limitranges,pods,replicasets.apps,clusterclasses.cluster.x-k8s.io,-,clusterbootstraps.run.tanzu.vmware.com,clusters.cluster.x-k8s.io,clusterresourcesets.addons.cluster.x-k8s.io)
      --store-validation-frequency 0s                       How often to verify if the storage is valid. Optional. Set this to 0s to disable sync. Default 1 minute. (default 1m0s)
      --terminating-resource-timeout duration               How long to wait on persistent volumes and namespaces to terminate during a restore before timing out. (default 10m0s)

Global Flags:
      --add_dir_header                   If true, adds the file directory to the header
      --alsologtostderr                  log to standard error as well as files
      --colorized optionalBool           Show colored output in TTY. Overrides 'colorized' value from $HOME/.config/velero/config.json if present. Enabled by default
      --features stringArray             Comma-separated list of features to enable for this Velero process. Combines with values from $HOME/.config/velero/config.json if present
      --kubeconfig string                Path to the kubeconfig file to use to talk to the Kubernetes apiserver. If unset, try the environment variable KUBECONFIG, as well as in-cluster configuration
      --kubecontext string               The context to use to talk to the Kubernetes apiserver. If unset defaults to whatever your current-context is (kubectl config current-context)
      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
      --log_dir string                   If non-empty, write log files in this directory
      --log_file string                  If non-empty, use this log file
      --log_file_max_size uint           Defines the maximum size a log file can grow to. Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
      --logtostderr                      log to standard error instead of files (default true)
  -n, --namespace string                 The namespace in which Velero should operate (default "openshift-adp")
      --skip_headers                     If true, avoid header prefixes in the log messages
      --skip_log_headers                 If true, avoid headers when opening log files
      --stderrthreshold severity         logs at or above this threshold go to stderr (default 2)
  -v, --v Level                          number for the log level verbosity
      --vmodule moduleSpec               comma-separated list of pattern=N settings for file-filtered logging

output of ❯ yq '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.configuration.properties.velero.properties.args' bundle/manifests/oadp.openshift.io_dataprotectionapplications.yaml

description: Velero args are settings to customize velero server arguments. Overrides values in other fields.
properties:
  add_dir_header:
    description: If true, add the file directory to the header
    type: boolean
  alsologtostderr:
    type: boolean
  backup-sync-period:
    description: How often to ensure all Velero backups in object storage exist as Backup API objects in the cluster. This is the default sync period if none is explicitly specified for a backup storage location.
    format: int64
    type: integer
  client-burst:
    description: Maximum number of requests by the server to the Kubernetes API in a short period of time.
    type: integer
  client-page-size:
    description: Page size of requests by the server to the Kubernetes API when listing objects during a backup. Set to 0 to disable paging.
    type: integer
  client-qps:
    description: Maximum number of requests per second by the server to the Kubernetes API once the burst limit has been reached. this will be validated as a valid float32
    type: integer
  colorized:
    description: Show colored output in TTY
    enum:
      - EnableCSI
      - EnableAPIGroupVersions
      - EnableUploadProgress
    type: boolean
  default-backup-ttl:
    description: default 720h0m0s
    format: int64
    type: integer
  default-restic-maintenance-frequency:
    description: default 168h0m0s
    format: int64
    type: integer
  default-volumes-to-restic:
    description: Backup all volumes with restic by default.
    type: boolean
  disabled-controllers:
    description: List of controllers to disable on startup. Valid values are backup,backup-deletion,backup-sync,download-request,gc,restic-repo,restore,schedule,server-status-request
    enum:
      - backup
      - backup-deletion
      - backup-storage-location
      - backup-sync
      - download-request
      - gc
      - pod-volume-backup
      - pod-volume-restore
      - restic-repo
      - restore
      - schedule
      - server-status-request
    items:
      type: string
    type: array
  garbage-collection-frequency:
    description: How long to wait by default before backups can be garbage collected. (default 720h0m0s)
    format: int64
    type: integer
  log-format:
    description: The format for log output. Valid values are text, json. (default text)
    enum:
      - text
      - json
    type: string
  log_backtrace_at:
    description: when logging hits line file:N, emit a stack trace
    type: integer
  log_dir:
    description: If non-empty, overrides the choice of directory in which to write logs. See createLogDirs for the full list of possible destinations.
    type: string
  log_file:
    description: If non-empty, specifies the path of the file to write logs. mutually exclusive with the log_dir option.
    type: string
  log_file_max_size:
    description: When logFile is specified, this limiter makes sure the logFile won't exceeds a certain size. When exceeds, the logFile will be cleaned up. If this value is 0, no size limitation will be applied to logFile.
    format: int64
    type: integer
  logtostderr:
    description: 'Boolean flags. Not handled atomically because the flag.Value interface does not let us avoid the =true, and that shorthand is necessary for compatibility. TODO: does this matter enough to fix? Seems unlikely.'
    type: boolean
  metrics-address:
    description: The address to expose prometheus metrics
    type: string
  one_output:
    description: If true, messages will not be propagated to lower severity log levels
    type: boolean
  profiler-address:
    description: The address to expose the pprof profiler.
    type: string
  restic-timeout:
    description: How long backups/restores of pod volumes should be allowed to run before timing out.
    format: int64
    type: integer
  restore-resource-priorities:
    description: Default CSI snapshot timeout is not a flag in velero server defaultCSISnapshotTimeout  time.Duration `json:"default-csi-snapshot-timeout"`
    type: string
  skip_headers:
    description: If true, do not add the prefix headers, useful when used with SetOutput
    type: boolean
  skip_log_headers:
    description: If true, do not add the headers to log files
    type: boolean
  stderrthreshold:
    description: Level flag. Handled atomically.
    type: integer
  store-validation-frequency:
    description: How often to verify if the storage is valid. Optional. Set this to `0s` to disable sync. Default 1 minute.
    format: int64
    type: integer
  terminating-resource-timeout:
    description: How long to wait on persistent volumes and namespaces to terminate during a restore before timing out.
    format: int64
    type: integer
  v:
    description: number for the log level verbosity
    type: integer
  vmodule:
    description: comma-separated list of pattern=N settings for file-filtered logging
    type: string
type: object

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[kaovilai]

/retest

[kaovilai]

/retest

[openshift-ci]

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eemcmullan, kaovilai, shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [eemcmullan,kaovilai,shubham-pampattiwar,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kaovilai]

/unhold