Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: openapiconfig: generate base config using DefaultOpenAPIConfig #111

Merged
merged 1 commit into from Apr 25, 2024

Conversation

liouk
Copy link
Member

@liouk liouk commented Apr 23, 2024

This PR addresses this comment: #108 (comment)

/assign @p0lyn0mial

Copy link

openshift-ci bot commented Apr 23, 2024

@liouk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@p0lyn0mial
Copy link
Contributor

thanks!

/lgtm
/assign @stlaz

for approval.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@stlaz
Copy link
Member

stlaz commented Apr 25, 2024

/approve

Copy link

openshift-ci bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liouk, p0lyn0mial, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@liouk
Copy link
Member Author

liouk commented Apr 25, 2024

/retitle NO ISSUE: openapiconfig: generate base config using DefaultOpenAPIConfig

@openshift-ci openshift-ci bot changed the title openapiconfig: generate base config using DefaultOpenAPIConfig NO ISSUE: openapiconfig: generate base config using DefaultOpenAPIConfig Apr 25, 2024
@liouk
Copy link
Member Author

liouk commented Apr 25, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@liouk: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@liouk
Copy link
Member Author

liouk commented Apr 25, 2024

/retitle NO-ISSUE: openapiconfig: generate base config using DefaultOpenAPIConfig

@openshift-ci openshift-ci bot changed the title NO ISSUE: openapiconfig: generate base config using DefaultOpenAPIConfig NO-ISSUE: openapiconfig: generate base config using DefaultOpenAPIConfig Apr 25, 2024
@openshift-ci-robot
Copy link
Contributor

@liouk: This pull request explicitly references no jira issue.

In response to this:

This PR addresses this comment: #108 (comment)

/assign @p0lyn0mial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fa1f097 into openshift:master Apr 25, 2024
8 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-oauth-apiserver-container-v4.16.0-202404250649.p0.gfa1f097.assembly.stream.el9 for distgit ose-oauth-apiserver.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants