Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1894345: [release-4.6] register api groups to legacyscheme.Scheme early #27

Merged
merged 1 commit into from Nov 25, 2020
Merged

Bug 1894345: [release-4.6] register api groups to legacyscheme.Scheme early #27

merged 1 commit into from Nov 25, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #26

/assign marun

@p0lyn0mial @marun
register api groups to legacyscheme.Scheme early
023a357 
all sort of things rely on the types being registered into the scheme without bad things can happen.

for example, the type namer used to construct the OpenAPI spec uses it to build its internal state.
The final spec might be incomplete if not all types were registered.

Co-authored-by:  Maru Newby <marun@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 6, 2020
Merged
@marun
Copy link
Contributor

marun commented Nov 6, 2020

/retitle Bug 1894345: [release-4.6] register api groups to legacyscheme.Scheme early

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] register api groups to legacyscheme.Scheme early Bug 1894345: [release-4.6] register api groups to legacyscheme.Scheme early Nov 6, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 6, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1894345, which is invalid:

  • expected dependent Bugzilla bug 1894342 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1894345: [release-4.6] register api groups to legacyscheme.Scheme early

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marun
Copy link
Contributor

marun commented Nov 6, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 6, 2020
@openshift-ci-robot
Copy link
Contributor

@marun: This pull request references Bugzilla bug 1894345, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1894342 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1894342 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Contributor

sttts commented Nov 7, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 7, 2020
@rhpmali
Copy link

rhpmali commented Nov 9, 2020

/bugzilla cc-qa

@openshift-ci-robot
Copy link
Contributor

@rhpmali: This pull request references Bugzilla bug 1894345, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1894342 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1894342 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (pmali@redhat.com), skipping review request.

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhpmali
Copy link

rhpmali commented Nov 9, 2020

/bugzilla cc-qa

@openshift-ci-robot
Copy link
Contributor

@rhpmali: This pull request references Bugzilla bug 1894345, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1894342 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1894342 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

Requesting review from QA contact:
/cc @rhpmali

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhpmali
Copy link

rhpmali commented Nov 9, 2020

Verification steps: https://bugzilla.redhat.com/show_bug.cgi?id=1894345#c1

@rhpmali
Copy link

rhpmali commented Nov 9, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rhpmali, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 25, 2020
@p0lyn0mial p0lyn0mial mentioned this pull request Nov 25, 2020
Merged
@openshift-merge-robot openshift-merge-robot merged commit 2151531 into openshift:release-4.6 Nov 25, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1894345 has been moved to the MODIFIED state.

In response to this:

Bug 1894345: [release-4.6] register api groups to legacyscheme.Scheme early

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@mrogers950 mrogers950 Awaiting requested review from mrogers950

@rhpmali rhpmali Awaiting requested review from rhpmali

Assignees

@marun marun

@sttts sttts

@rhpmali rhpmali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @marun @openshift-ci-robot @sttts @rhpmali @mfojtik @openshift-merge-robot @p0lyn0mial