Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1822727: Pick up PatternFly bug fix [1] for login templates #36

Merged
merged 1 commit into from Apr 8, 2020
Merged

Bug 1822727: Pick up PatternFly bug fix [1] for login templates #36

merged 1 commit into from Apr 8, 2020

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Mar 31, 2020 •
edited

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2020
@rhamilto
Copy link
Member Author

/hold for openshift/oauth-templates#7 and testing

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2020
@rhamilto rhamilto changed the title [WIP] Pick up PatternFly bug fix for login templates [WIP] Pick up PatternFly bug fix [1] for login templates Mar 31, 2020
@rhamilto rhamilto changed the title [WIP] Pick up PatternFly bug fix [1] for login templates Pick up PatternFly bug fix [1] for login templates Apr 1, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2020
@rhamilto
Copy link
Member Author

rhamilto commented Apr 1, 2020

/hold cancel

tested and ready for merge

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2020
@rhamilto
Copy link
Member Author

rhamilto commented Apr 1, 2020

/hold

just found an upstream regression in PatternFly :(

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2020
@rhamilto
Copy link
Member Author

rhamilto commented Apr 1, 2020

/hold cancel

upstream bug fix applied.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2020
@rhamilto
Copy link
Member Author

rhamilto commented Apr 1, 2020

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Apr 1, 2020

@stlas, PTAL.

@rhamilto
Copy link
Member Author

rhamilto commented Apr 1, 2020

/retest

1 similar comment
@rhamilto
Copy link
Member Author

rhamilto commented Apr 1, 2020

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Apr 1, 2020

/hold

the bug fix introduced a new bug. :/

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2020
@rhamilto
Copy link
Member Author

rhamilto commented Apr 1, 2020

/hold cancel

fixed buggy fix. ready for review.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2020
@rhamilto
Copy link
Member Author

rhamilto commented Apr 2, 2020

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Apr 3, 2020

@stlaz, please review.

@stlaz
Copy link
Member

stlaz commented Apr 8, 2020

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2020
@openshift-merge-robot openshift-merge-robot merged commit df270dc into openshift:master Apr 8, 2020
@rhamilto rhamilto deleted the upstream-bug-fix branch April 8, 2020 12:05
@rhamilto
Copy link
Member Author

rhamilto commented Apr 9, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 9, 2020
Merged
@openshift-cherrypick-robot
Copy link

@rhamilto: new pull request created: #38

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto rhamilto changed the title Pick up PatternFly bug fix [1] for login templates Bug 1822727: Pick up PatternFly bug fix [1] for login templates Apr 9, 2020
@openshift-ci-robot
Copy link
Contributor

@rhamilto: All pull requests linked via external trackers have merged: . Bugzilla bug 1822727 has been moved to the MODIFIED state.

In response to this:

Bug 1822727: Pick up PatternFly bug fix [1] for login templates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@stlaz stlaz Awaiting requested review from stlaz

Assignees

@stlaz stlaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rhamilto @stlaz @openshift-ci-robot @openshift-cherrypick-robot @openshift-merge-robot