Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new access token inactivity timeout field #49

Conversation

vareti
Copy link
Contributor

@vareti vareti commented Jun 25, 2020

This PR aims to use consistent field name for access token inactivity timeout. It uses the new fields that were added to token config oauth cluster config and osin config.

@stlaz
Copy link
Member

stlaz commented Jun 26, 2020

/hold
contains fake bump

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2020
@vareti vareti force-pushed the replace-access-token-inactivity-timeout-second-with-new-field branch from c7b56c5 to 0116256 Compare June 29, 2020 20:13
@vareti vareti force-pushed the replace-access-token-inactivity-timeout-second-with-new-field branch from 0116256 to 9f6d467 Compare July 13, 2020 13:51
@vareti
Copy link
Contributor Author

vareti commented Jul 13, 2020

/hold cancel

/assign @stlaz

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2020
@vareti
Copy link
Contributor Author

vareti commented Jul 14, 2020

/retest

@stlaz
Copy link
Member

stlaz commented Jul 15, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 15, 2020
@sttts
Copy link
Contributor

sttts commented Jul 15, 2020

"Pending — Not mergeable." What does this mean?

@sttts
Copy link
Contributor

sttts commented Jul 15, 2020

/lgtm
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stlaz, sttts, vareti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants