[WIP] feat: split archive functionality #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpower432
force-pushed
the
feat/bundle-archiving
branch
from
5387a01
to
ee52029
Compare
jpower432
changed the title
afflom
reviewed
Jul 26, 2021
| @@ -0,0 +1,184 @@ | |||
| package archive | |||
There was a problem hiding this comment.
With regard to portability, I think that this might best added as a subpackage to bundle. Thoughts?
There was a problem hiding this comment.
@afflom I considered it a functional component outside of the bundle that interacts with bundles, but I would be willing to move it under bundle as a sub package.
There was a problem hiding this comment.
I vote making it a sub-package. I asked Eric for his opinion.
There was a problem hiding this comment.
Since we don't yet know how these packages/command will look when integrating with oc, this is fine for now. Once we know those requirements, we can reorganize packages if needed.
jpower432
force-pushed
the
feat/bundle-archiving
branch
from
b89e1e6
to
227d85d
Compare
|
@afflom, as discussed, a couple notes/request for change:
|
jpower432
force-pushed
the
feat/bundle-archiving
branch
from
ebbca4b
to
880b306
Compare
jpower432
changed the title
|
Closing this. OBE per pull request #28 |
dorzel
pushed a commit
to dorzel/oc-mirror
that referenced
this pull request
May 24, 2023
- Update the .goreleaser.yaml to include s390x - Update the cross build for s390x - Link gcc to s390x-linux-gnu-gcc binary On s390x go compiler seems to expect the gcc binary at s390x-linux-gnu-gcc binary. However on rhel it is not installed there. Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
openshift-merge-robot
pushed a commit
that referenced
this pull request
Jun 8, 2023
…sing dockerfile and add ppc64le build to Makefile (#624) * MULTIARCH-3440: refine multiarch support for test-unit and test-e2e using dockerfile and add ppc64le build to Makefile - Update the .goreleaser.yaml to include ppc64le - Update the Dockerfile to include wget and pigz dependency - Update the Dockerfile to consider arch it's built on - Update the util.sh to be arch agnostic - Update the cross build for ppc64le Signed-off-by: Paul Bastide <pbastide@redhat.com> * MULTIARCH-3440: Update per review Signed-off-by: Paul Bastide <pbastide@us.ibm.com> Co-authored-by: Jan Schintag <43986265+jschintag@users.noreply.github.com> * MULTIARCH-3441: Enable builds for s390x (#1) - Update the .goreleaser.yaml to include s390x - Update the cross build for s390x - Link gcc to s390x-linux-gnu-gcc binary On s390x go compiler seems to expect the gcc binary at s390x-linux-gnu-gcc binary. However on rhel it is not installed there. Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com> * MULTIARCH-3441: Enable builds for s390x (#1) (#2) - Update the .goreleaser.yaml to include s390x - Update the cross build for s390x - Link gcc to s390x-linux-gnu-gcc binary On s390x go compiler seems to expect the gcc binary at s390x-linux-gnu-gcc binary. However on rhel it is not installed there. Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com> * MULTIARCH-3440: update the code to use go-containerregistry for all arches and add arm64 Signed-off-by: Paul Bastide <pbastide@redhat.com> * MULTIARCH-3440: Adding cross-build for arm64 Signed-off-by: Paul Bastide <pbastide@redhat.com> --------- Signed-off-by: Paul Bastide <pbastide@redhat.com> Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com> Co-authored-by: Jan Schintag <43986265+jschintag@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features added: