feat(operator): catalog metadata types for prior index data #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
changed the title
|
Blocking on #28 so I can rebase. |
jpower432
reviewed
Aug 11, 2021
| return err | ||
| case err == nil && len(meta.PastMirrors) != 0: | ||
| // No past run(s) are allowed when generating a full imageset. | ||
| // QUESTION: should the command just log a warning and ignore this metadata instead? |
There was a problem hiding this comment.
@estroz Responding to your comment in the code, would it better to prompt the user or would we send a warning when creating a full and destroy the current metadata. @afflom and I talked about this and the user should be able to create a full even if there is existing metadata, but the only area of concern I have about this is the user accidentally running create full. Maybe a prompt or a metadata backup? WDYT?
There was a problem hiding this comment.
Prompt sounds fine. I'll create a follow-up.
jpower432
requested changes
Aug 11, 2021
This commit also hoists the Uid field to the top-level MetadataSpec object, since it identifies the whole metadata object and not just an individual run. Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
estroz
commented
Aug 11, 2021
| if err != nil { | ||
| return fmt.Errorf("creating %s: %v", nameInArchive, err) | ||
| } | ||
| if _, found := foundFiles[fpath]; !found { |
There was a problem hiding this comment.
Just moved the actual archive logic left and indent, and localized the skip logic. No semantic changes made other than skipping . explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to store and pull image set metadata from a backend, and fixes some
createmetadata handling issues. Currently only a local directory storage backend is supported.Signed-off-by: Eric Stroczynski ericstroczynski@gmail.com