CFE-904: Create AdditionalImage Collector implem. based on registry as localStore

[sherine-k]

Description

This PR initializes a local registry at initialization of the executor.
The local registry is based on github.com/distribution/distribution.
The registry starts on HTTP port 5000, and uses a filesystem driver as storage.
Its storage root directory depends on the mirroring workflow that is picked up from the command line.

• For Mirror to Disk workflow :
  • The command will be like : build/mirror --config isc.yaml file:///tmp/the-store
  • And the storage root directory will be /tmp/the-store
• For Disk to Mirror workflow:
  • The command will be like : build/mirror --config isc.yaml --from file:///tmp/the-store docker://localhost:6000/test2 --dest-tls-verify=false --src-tls-verify=false
  • And the storage root directory will be /tmp/the-store

Fixes # CFE-904

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Using the following imageSetConfig, we performed:

• MirrorToDisk workflow

build/mirror --config isc.yaml file:///tmp/the-store

• DiskToMirror workflow

build/mirror --config isc.yaml --from file:///tmp/the-store docker://localhost:6000/test2 --dest-tls-verify=false --src-tls-verify=false

Test Configuration:

• ImageSetConfig (isc.yaml):

# This config demonstrates how to mirror a version range
# in the specified channel for an OpenShift release.
---
apiVersion: mirror.openshift.io/v1alpha2
kind: ImageSetConfiguration
mirror:
  additionalImages: 
    - name: registry.redhat.io/ubi8/ubi:latest
    - name: registry.redhat.io/ubi9/ubi:latest

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[openshift-ci-robot]

@sherine-k: This pull request references CFE-904 which is a valid jira issue.

In response to this:

Description

This PR initializes a local registry at initialization of the executor.
The local registry is based on github.com/distribution/distribution.
The registry starts on HTTP port 5000, and uses a filesystem driver as storage.
Its storage root directory depends on the mirroring workflow that is picked up from the command line.

• For Mirror to Disk workflow :
  • The command will be like : build/mirror --config isc.yaml file:///tmp/the-store
  • And the storage root directory will be /tmp/the-store
• For Disk to Mirror workflow:
  • The command will be like : build/mirror --config isc.yaml --from file:///tmp/the-store docker://localhost:6000/test2 --dest-tls-verify=false --src-tls-verify=false
  • And the storage root directory will be /tmp/the-store

Fixes # CFE-904

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Using the following imageSetConfig, we performed:

• MirrorToDisk workflow

build/mirror --config isc.yaml file:///tmp/the-store

• DiskToMirror workflow

build/mirror --config isc.yaml --from file:///tmp/the-store docker://localhost:6000/test2 --dest-tls-verify=false --src-tls-verify=false

Test Configuration:

• ImageSetConfig (isc.yaml):

# This config demonstrates how to mirror a version range
# in the specified channel for an OpenShift release.
---
apiVersion: mirror.openshift.io/v1alpha2
kind: ImageSetConfiguration
mirror:
 additionalImages: 
   - name: registry.redhat.io/ubi8/ubi:latest
   - name: registry.redhat.io/ubi9/ubi:latest

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sherine-k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lmzuccarelli]

other than this looks good to me

[sherine-k]

/hold

[aguidirh]

/lgtm

[aguidirh]

/lgtm

[sherine-k]

/unhold

[openshift-ci]

@sherine-k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[aguidirh]

/lgtm

[sherine-k]

/lgtm

[openshift-ci]

@sherine-k: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.