OCPBUGS-17714: Ensure errors are nil before closing registry to avoid…

[lmzuccarelli]

… panic

This fix ensures errors are nil before trying to close the registry, this will avoid a panic

Fixes # OCPBUGS-17714

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Verified locally with the following registries.config and Image Set Config

  location = "registry.redhat.io"
  insecure = false
  blocked = false
  mirror-by-digest-only = false
  prefix = ""
  [[registry.mirror]]
    location = "localhost:5000"
    insecure = true

Image Set Config

kind: ImageSetConfiguration
mirror:
  operators:
    - catalog: oci://ocpbugs-17714
      packages:
      - name: aws-load-balancer-operator

Test Configuration:

• Firmware version:
• Hardware:
• Toolchain:
• SDK:

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[openshift-ci-robot]

@lmzuccarelli: This pull request references Jira Issue OCPBUGS-17714, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

… panic

This fix ensures errors are nil before trying to close the registry, this will avoid a panic

Fixes # OCPBUGS-17714

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Verified locally with the following registries.config and Image Set Config

 location = "registry.redhat.io"
 insecure = false
 blocked = false
 mirror-by-digest-only = false
 prefix = ""
 [[registry.mirror]]
   location = "localhost:5000"
   insecure = true

Image Set Config

kind: ImageSetConfiguration
mirror:
 operators:
   - catalog: oci://ocpbugs-17714
     packages:
     - name: aws-load-balancer-operator

Test Configuration:

• Firmware version:
• Hardware:
• Toolchain:
• SDK:

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmzuccarelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lmzuccarelli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zhouying7780]

/label qe-approved

[sherine-k]

/lgtm

[openshift-ci]

@lmzuccarelli: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@lmzuccarelli: Jira Issue OCPBUGS-17714: All pull requests linked via external trackers have merged:

• openshift/oc-mirror#680

Jira Issue OCPBUGS-17714 has been moved to the MODIFIED state.

In response to this:

… panic

This fix ensures errors are nil before trying to close the registry, this will avoid a panic

Fixes # OCPBUGS-17714

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Verified locally with the following registries.config and Image Set Config

 location = "registry.redhat.io"
 insecure = false
 blocked = false
 mirror-by-digest-only = false
 prefix = ""
 [[registry.mirror]]
   location = "localhost:5000"
   insecure = true

Image Set Config

kind: ImageSetConfiguration
mirror:
 operators:
   - catalog: oci://ocpbugs-17714
     packages:
     - name: aws-load-balancer-operator

Test Configuration:

• Firmware version:
• Hardware:
• Toolchain:
• SDK:

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.