Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-18556: operator catalogs from oc-mirror fail to deploy because of invalid caches #691

Merged
merged 3 commits into from Sep 11, 2023
Merged

[release-4.13] OCPBUGS-18556: operator catalogs from oc-mirror fail to deploy because of invalid caches #691

merged 3 commits into from Sep 11, 2023

Conversation

sherine-k
Copy link
Contributor

This PR is a manual cherrypick of:

It allows for the cache to be regenerated upon catalog rebuild, so that the cache is valid in regards to the newly filtered declarative config and passes cache-integrity check upon catalog startup on the cluster.

@sherine-k
CFE-825: As a oc-mirror user, I would like mirrored operator catalogs…
adac5bf 
… to have valid caches (openshift#651)

* Regenerate opm cache when building catalog images

* Recreate the cache of local OCI catalogs

* Incomplete - Include opm cache integrity verification to E2E
Fix code regarding finding the location of the opm binary

* TEMPORARY: use a different repository for source catalogs
Fix E2E test catalog_full

* Make cache regeneration during catalog rebuild conditional based on presence of argument `--cache-dir` in the original image container CMD

* Fix review comments
@sherine-k
OCPBUGS-17545: Improve extracting opm binary from catalogs (openshift…
05e641f 
…#676)

* Improve extracting opm binary from catalogs

* Fix OCPBUGS-17545 - Force pull catalog by platform architecture

* Rewrite extractOPMBinary in a non-recursive way

* Attempt 2 -  Rewrite extractOPMBinary in a non-recursive way
This new implementation extracts the whole catalog to a local folder in order to make it easier to grab the opm binary.

* Account for cases where catalog image's entrypoint might be empty

* Add comments to opm binary extraction logic
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 8, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 8, 2023 •
edited by openshift-ci bot

@sherine-k: This pull request references Jira Issue OCPBUGS-18556, which is invalid:

  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent Jira Issue OCPBUGS-17545 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents
  • dependent bug CFE-825 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR is a manual cherrypick of:

It allows for the cache to be regenerated upon catalog rebuild, so that the cache is valid in regards to the newly filtered declarative config and passes cache-integrity check upon catalog startup on the cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2023
@sherine-k
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@sherine-k: This pull request references Jira Issue OCPBUGS-18556, which is invalid:

  • expected dependent Jira Issue OCPBUGS-17545 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 8, 2023

@sherine-k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lmzuccarelli
Copy link
Contributor

/lgtm

@lmzuccarelli
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 8, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2023
@zhouying7780
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 11, 2023
@zhouying7780
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 11, 2023
@sherine-k
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 11, 2023
@openshift-ci-robot
Copy link

@sherine-k: This pull request references Jira Issue OCPBUGS-18556, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-17545 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-17545 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 11, 2023
@openshift-merge-robot openshift-merge-robot merged commit 07d39c8 into openshift:release-4.13 Sep 11, 2023
5 checks passed
@openshift-ci-robot
Copy link

@sherine-k: Jira Issue OCPBUGS-18556: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-18556 has been moved to the MODIFIED state.

In response to this:

This PR is a manual cherrypick of:

It allows for the cache to be regenerated upon catalog rebuild, so that the cache is valid in regards to the newly filtered declarative config and passes cache-integrity check upon catalog startup on the cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.13.0-0.nightly-2023-09-11-194803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@jpower432 jpower432 Awaiting requested review from jpower432

Assignees

@lmzuccarelli lmzuccarelli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sherine-k @openshift-ci-robot @lmzuccarelli @zhouying7780 @openshift-merge-robot