CFE-956: [v2] feat: adds tags on the related images

[aguidirh]

Description

Before this implementation the related images were being stored only by digest. Now the related images are going to have a tag that is the 12 first chars of its digest.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

apiVersion: mirror.openshift.io/v1alpha2
kind: ImageSetConfiguration
mirror:
  operators:
    - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.12
      packages:
        - name: aws-load-balancer-operator
  additionalImages: 
    - name: registry.redhat.io/ubi8/ubi
    - name: registry.redhat.io/ubi9/ubi

MirrorToDisk

./bin/oc-mirror -c /home/aguidi/go/src/github.com/aguidirh/oc-mirror/alex-isc/isc.yaml file:///home/aguidi/go/src/github.com/aguidirh/oc-mirror/CFE-956-v2 --v2

DiskToMirror

./bin/oc-mirror -c /home/aguidi/go/src/github.com/aguidirh/oc-mirror/alex-isc/isc-additional-image.yaml --from /home/aguidi/go/src/github.com/aguidirh/oc-mirror/CFE-956-v2 docker://localhost:9000 --v2

One example of tags with the first 12 chars of the digest:

[aguidi@fedora oc-mirror]$ curl -X GET http://localhost:9000/v2/registry.redhat.io/albo/aws-load-balancer-controller-rhel8/tags/list | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   124  100   124    0     0  25218      0 --:--:-- --:--:-- --:--:-- 31000
{
  "name": "registry.redhat.io/albo/aws-load-balancer-controller-rhel8",
  "tags": [
    "d7bc36451217",
    "cfd210a2cb70",
    "cad8f6380b4d"
  ]
}

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[openshift-ci-robot]

@aguidirh: This pull request references CFE-956 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

In response to this:

Description

Before this implementation the related images were being stored only by digest. Now the related images are going to have a tag that is the 12 first chars of its digest.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

apiVersion: mirror.openshift.io/v1alpha2
kind: ImageSetConfiguration
mirror:
 operators:
   - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.12
     packages:
       - name: aws-load-balancer-operator
 additionalImages: 
   - name: registry.redhat.io/ubi8/ubi
   - name: registry.redhat.io/ubi9/ubi

MirrorToDisk

./bin/oc-mirror -c /home/aguidi/go/src/github.com/aguidirh/oc-mirror/alex-isc/isc.yaml file:///home/aguidi/go/src/github.com/aguidirh/oc-mirror/CFE-956-v2 --v2

DiskToMirror

./bin/oc-mirror -c /home/aguidi/go/src/github.com/aguidirh/oc-mirror/alex-isc/isc-additional-image.yaml --from /home/aguidi/go/src/github.com/aguidirh/oc-mirror/CFE-956-v2 docker://localhost:9000 --v2

One example of tags with the first 12 chars of the digest:

[aguidi@fedora oc-mirror]$ curl -X GET http://localhost:9000/v2/registry.redhat.io/albo/aws-load-balancer-controller-rhel8/tags/list | jq
 % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                Dload  Upload   Total   Spent    Left  Speed
100   124  100   124    0     0  25218      0 --:--:-- --:--:-- --:--:-- 31000
{
 "name": "registry.redhat.io/albo/aws-load-balancer-controller-rhel8",
 "tags": [
   "d7bc36451217",
   "cfd210a2cb70",
   "cad8f6380b4d"
 ]
}

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lmzuccarelli]

great work @aguidirh 👍

[lmzuccarelli]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aguidirh, lmzuccarelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lmzuccarelli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sherine-k]

Thanks Alex,
This clarifies the code by much and fixes this issue we've been having with pulling the images!

[openshift-ci]

@aguidirh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sherine-k]

/lgtm