OCPBUGS-22947: Should not generate graph with prepare subcommand

[sherine-k]

Description

This issue fixes the panic that was happening during the use of prepare subcommand, because the graph image was getting generated, at a time where the subcommand does not create an ImageBuilder for the CreateGraphImage to use.

Fixes # OCPBUGS-22947

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Prepare subcommand

./bin/oc-mirror --v2 prepare -c cfe-969.yml --from file:///home/skhoury/release 

• Disk to mirror workflow

./bin/oc-mirror --v2 -c cfe-969.yml --from file:///home/skhoury/release docker://localhost:5000/cfe969

Expected Outcome

Both commands should succeed and not panic

[openshift-ci-robot]

@sherine-k: This pull request references Jira Issue OCPBUGS-22947, which is invalid:

• expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Description

This issue fixes the panic that was happening during the use of prepare subcommand, because the graph image was getting generated, at a time where the subcommand does not create an ImageBuilder for the CreateGraphImage to use.

Fixes # OCPBUGS-22947

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Prepare subcommand

./bin/oc-mirror --v2 prepare -c cfe-969.yml --from file:///home/skhoury/release 

• Disk to mirror workflow

./bin/oc-mirror --v2 -c cfe-969.yml --from file:///home/skhoury/release docker://localhost:5000/cfe969

Expected Outcome

Both commands should succeed and not panic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sherine-k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sherine-k]

/jira refresh

[openshift-ci-robot]

@sherine-k: This pull request references Jira Issue OCPBUGS-22947, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aguidirh]

/lgtm

[openshift-ci]

@sherine-k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@sherine-k: Jira Issue OCPBUGS-22947: All pull requests linked via external trackers have merged:

• openshift/oc-mirror#725

Jira Issue OCPBUGS-22947 has been moved to the MODIFIED state.

In response to this:

Description

This issue fixes the panic that was happening during the use of prepare subcommand, because the graph image was getting generated, at a time where the subcommand does not create an ImageBuilder for the CreateGraphImage to use.

Fixes # OCPBUGS-22947

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Prepare subcommand

./bin/oc-mirror --v2 prepare -c cfe-969.yml --from file:///home/skhoury/release 

• Disk to mirror workflow

./bin/oc-mirror --v2 -c cfe-969.yml --from file:///home/skhoury/release docker://localhost:5000/cfe969

Expected Outcome

Both commands should succeed and not panic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2023-11-07-012445