DO_NOT_MERGE - CFE-977: Implementation of a blob gatherer for images in the local cache #730
Conversation
sherine-k
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@sherine-k: This pull request references CFE-977 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sherine-k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
|
@sherine-k: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
sherine-k
changed the title
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
| @@ -348,7 +348,3 @@ func parseMultiArch(multiArch string) (copy.ImageListSelection, error) { | |||
| return copy.CopySystemImage, fmt.Errorf("unknown multi-arch option %q. Choose one of the supported options: 'system', 'all', or 'index-only'", multiArch) | |||
| } | |||
| } | |||
|
|
|||
| func HelloFromV2() string { | |||
There was a problem hiding this comment.
Thanks for removing this func.
|
Closed in favor of #732 |
Description
This PR is part of a larger user story CFE-977 - Generate smaller archives
In this PR, we focus on identifying those blobs (both layers, config and manifests of various formats (docker-v2 or oci), both single arch and multi arch) that form a container image that is saved to oc-mirror's local cache.
The implementation relies on reading the storage folder of that local cache.
While I agree that this is rather intrusive into the way the local cache registry stores the blobs on disk, it is a fairly easy implementation.
Another implementation might follow in another PR that could interact with the local cache registry instead of looking directly on disk.
For the moment, the use of BlobGatherer is not fully integrated with the MirrorToDisk workflow. Following PRs will be in charge of that.
Fixes # CFE-979
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests for BlobGatherer where implemented
Expected Outcome
Tests should pass