New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFE-977,CFE-981: unarchiver interface and its implementation #738
Conversation
@sherine-k: This pull request references CFE-977 which is a valid jira issue. This pull request references CFE-981 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sherine-k: This pull request references CFE-977 which is a valid jira issue. This pull request references CFE-981 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sherine-k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@sherine-k: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build oc-mirror-plugin-container-v4.15.0-202311272131.p0.g8f9caef.assembly.stream for distgit oc-mirror-plugin. |
Description
Unarchive simply untars the contents of the archive into:
docker/v2
found in the archive)Fixes # CFE-981
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit test unarchive_test.go
This interface is not yet plugged into executor.go, but should be later, with CFE-992
Expected Outcome
Unit tests should pass