Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-977,CFE-981: unarchiver interface and its implementation #738

Merged
merged 1 commit into from Nov 27, 2023

Conversation

sherine-k
Copy link
Contributor

@sherine-k sherine-k commented Nov 27, 2023

Description

Unarchive simply untars the contents of the archive into:

  • working-dir (for subfolders of working-dir found in the archive)
  • cache folder (for subfolders of docker/v2 found in the archive)

Fixes # CFE-981

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit test unarchive_test.go
This interface is not yet plugged into executor.go, but should be later, with CFE-992

Expected Outcome

Unit tests should pass

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 27, 2023

@sherine-k: This pull request references CFE-977 which is a valid jira issue.

This pull request references CFE-981 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

In response to this:

Description

Unarchive simply untars the contents of the archive into:

  • working-dir (for subfolders of working-dir found in the archive)
  • cache folder (for subfolders of docker/v2 found in the archive)

Fixes # CFE-980

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit test unarchive_test.go
This interface is not yet plugged into executor.go, but should be later, with CFE-992

Expected Outcome

Unit tests should pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 27, 2023

@sherine-k: This pull request references CFE-977 which is a valid jira issue.

This pull request references CFE-981 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

In response to this:

Description

Unarchive simply untars the contents of the archive into:

  • working-dir (for subfolders of working-dir found in the archive)
  • cache folder (for subfolders of docker/v2 found in the archive)

Fixes # CFE-981

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit test unarchive_test.go
This interface is not yet plugged into executor.go, but should be later, with CFE-992

Expected Outcome

Unit tests should pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@lmzuccarelli
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
@sherine-k sherine-k changed the title WIP: CFE-977,CFE-981: unarchiver interface and its implementation CFE-977,CFE-981: unarchiver interface and its implementation Nov 27, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2023
Copy link

openshift-ci bot commented Nov 27, 2023

@sherine-k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8f9caef into openshift:main Nov 27, 2023
5 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build oc-mirror-plugin-container-v4.15.0-202311272131.p0.g8f9caef.assembly.stream for distgit oc-mirror-plugin.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants