CFE-977,CFE-991: archive generation at the end of MirrorToDisk workflow #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done to anticipate instanciation of Archiver in the Executor.go. In fact, the cobra command context will only be available in the Run method. The calls to `archive.NewMirrorArchive` which are expected in methods Complete and PrepareComplete of the executor happen before Run, and therefore the context of the command isn't created yet. Therefore, we are moving the context argument from `NewImageBlobGatherer` and `NewMirrorArchive` into the methods `GatherBlobs` and `BuildArchive` respectively.
openshift-ci-robot
added
the
jira/valid-reference
|
@sherine-k: This pull request references CFE-977 which is a valid jira issue. This pull request references CFE-991 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@sherine-k: This pull request references CFE-977 which is a valid jira issue. This pull request references CFE-991 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sherine-k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Adds the creation of an implementation of interface Archiver in the `Complete` method. Adds the call to Archiver.BuildArchive in `Run` for MirrorToDisk mode after the Batch workers have finished. Before building the archive, the local storage registry is stopped, so that we ensure that the cache folder is in a consistent state before we start archiving.
|
@sherine-k: This pull request references CFE-977 which is a valid jira issue. This pull request references CFE-991 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sherine-k
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@sherine-k: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[ART PR BUILD NOTIFIER] This PR has been included in build oc-mirror-plugin-container-v4.15.0-202311281631.p0.g030f65e.assembly.stream for distgit oc-mirror-plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrates previous PRs #734 into the MirrorToDisk workflow by
Fixes # CFE-991
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Expected Outcome
Control the tar contents: