OCPBUGS-23309: Do not panic if port chosen to run local cache is bound

[sherine-k]

Description

This PR fixes the panic that occurred when the port used by the local cache of oc-mirror v2 was already bound to another process by:

• using port 55000 as the default, instead of the more common 5000 port
• testing if the port is bound before invoking the go routine to create the local cache registry with that port

Fixes # OCPBUGS-23309

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• unit tests pass
• ./bin/oc-mirror --v2 --config cfe-966.yml --from file:///home/skhoury/release --dest-tls-verify=false docker://localhost:5000 uses port 55000
• ./bin/oc-mirror --v2 --config cfe-966.yml --from file:///home/skhoury/release --dest-tls-verify=false docker://localhost:5000 -p 5000 fails gracefully

Expected Outcome

╰─ (OCPBUGS-23309)-$ ./bin/oc-mirror  --v2 --config cfe-966.yml --from file:///home/skhoury/release  --dest-tls-verify=false docker://localhost:5000 -p 5000
--v2 flag identified, flow redirected to the oc-mirror v2 version. PLEASE DO NOT USE that. V2 is still under development and it is not ready to be used. 
2023/11/29 18:29:35  [INFO]   : mode diskToMirror 
2023/11/29 18:29:35  [ERROR]  :  5000 is already bound and cannot be used 

[openshift-ci-robot]

@sherine-k: This pull request references Jira Issue OCPBUGS-23309, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Description

This PR fixes the panic that occurred when the port used by the local cache of oc-mirror v2 was already bound to another process by:

• using port 55000 as the default, instead of the more common 5000 port
• testing if the port is bound before invoking the go routine to create the local cache registry with that port

Fixes # OCPBUGS-23309

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• unit tests pass
• ./bin/oc-mirror --v2 --config cfe-966.yml --from file:///home/skhoury/release --dest-tls-verify=false docker://localhost:5000 uses port 55000
• ./bin/oc-mirror --v2 --config cfe-966.yml --from file:///home/skhoury/release --dest-tls-verify=false docker://localhost:5000 -p 5000 fails gracefully

Expected Outcome

╰─ (OCPBUGS-23309)-$ ./bin/oc-mirror  --v2 --config cfe-966.yml --from file:///home/skhoury/release  --dest-tls-verify=false docker://localhost:5000 -p 5000
--v2 flag identified, flow redirected to the oc-mirror v2 version. PLEASE DO NOT USE that. V2 is still under development and it is not ready to be used. 
2023/11/29 18:29:35  [INFO]   : mode diskToMirror 
2023/11/29 18:29:35  [ERROR]  :  5000 is already bound and cannot be used 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sherine-k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@sherine-k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[lmzuccarelli]

/lgtm

[openshift-ci-robot]

@sherine-k: Jira Issue OCPBUGS-23309: All pull requests linked via external trackers have merged:

• openshift/oc-mirror#744

Jira Issue OCPBUGS-23309 has been moved to the MODIFIED state.

In response to this:

Description

This PR fixes the panic that occurred when the port used by the local cache of oc-mirror v2 was already bound to another process by:

• using port 55000 as the default, instead of the more common 5000 port
• testing if the port is bound before invoking the go routine to create the local cache registry with that port

Fixes # OCPBUGS-23309

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• unit tests pass
• ./bin/oc-mirror --v2 --config cfe-966.yml --from file:///home/skhoury/release --dest-tls-verify=false docker://localhost:5000 uses port 55000
• ./bin/oc-mirror --v2 --config cfe-966.yml --from file:///home/skhoury/release --dest-tls-verify=false docker://localhost:5000 -p 5000 fails gracefully

Expected Outcome

╰─ (OCPBUGS-23309)-$ ./bin/oc-mirror  --v2 --config cfe-966.yml --from file:///home/skhoury/release  --dest-tls-verify=false docker://localhost:5000 -p 5000
--v2 flag identified, flow redirected to the oc-mirror v2 version. PLEASE DO NOT USE that. V2 is still under development and it is not ready to be used. 
2023/11/29 18:29:35  [INFO]   : mode diskToMirror 
2023/11/29 18:29:35  [ERROR]  :  5000 is already bound and cannot be used 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2023-12-02-123536