-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLID-35: introduce filtering operators by selecting specific bundles #824
Conversation
@sherine-k: This pull request references CLID-35 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.17" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
82d7699
to
480a94b
Compare
@sherine-k: This pull request references CLID-35 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
@sherine-k: This pull request references CLID-35 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@aguidirh - I'll wait for you to chime in before adding labels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sherine-k,
This one is going to help our customers a lot, thanks!
Nit: suggested only small changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
|
||
relatedImages := make(map[string][]v1alpha3.RelatedImage) | ||
var filteredBundles []string | ||
defaultChannel := operatorConfig.Packages[operatorName].DefaultChannel | ||
|
||
if len(iscOperator.Channels) > 0 { | ||
switch { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changing to switch statement here, it is easier to understand now.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aguidirh, sherine-k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Using this ImageSetConfiguration:
I did mirrorToDisk, diskToMirror and checked if the related images for each bundle were in the target registry. Test Results: SUCCESS (all required blobs in the target registry for all bundles in the ImageSetConfiguration)
|
@sherine-k: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[ART PR BUILD NOTIFIER] This PR has been included in build oc-mirror-plugin-container-v4.16.0-202404181209.p0.g9ac063b.assembly.stream.el9 for distgit oc-mirror-plugin. |
Description
Implements part of S4 from operator filtering by direct selection of bundles .
This allows customers to explicitly point out the operator bundles for mirroring.
This helps in situations (especially future ones) where the customer has established the shortest path of upgrade for an operator in a tool external to oc-mirror, and would like to mirror only these bundle versions.
Fixes # CLID-35
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Using the following ImageSetConfig, perform a mirrorToDisk + diskToMirror.
Expected Outcome
Both M2D and D2M operators should succeed.
From the content of
working-dir/hold-operator/redhat-operator-index/856c0280c4cf6295ba47375c392b0c8c4298fc7a9534b8375d56125616e5a773/configs/aws-load-balancer-operator/catalog.json
, this is the list of images that should be available in the destination registry:for each image, perform a curl against the destination registry to verify that the image was copied, and that a tag corresponding to the digest given in the list above exists. Example:
Do the same for the 3scale operator.