Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLID-35: introduce filtering operators by selecting specific bundles #824

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

sherine-k
Copy link
Contributor

@sherine-k sherine-k commented Apr 5, 2024

Description

Implements part of S4 from operator filtering by direct selection of bundles .
This allows customers to explicitly point out the operator bundles for mirroring.
This helps in situations (especially future ones) where the customer has established the shortest path of upgrade for an operator in a tool external to oc-mirror, and would like to mirror only these bundle versions.

Fixes # CLID-35

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Using the following ImageSetConfig, perform a mirrorToDisk + diskToMirror.

kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v1alpha2
mirror:
  operators:
  - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.14
    packages:
    - name: aws-load-balancer-operator
      # channels:
      # - name: stable-4.13
      bundles:
      - name: aws-load-balancer-operator.v1.1.0
    - name: 3scale-operator
      bundles:
      - name: 3scale-operator.v0.10.0-mas

Expected Outcome

Both M2D and D2M operators should succeed.
From the content of working-dir/hold-operator/redhat-operator-index/856c0280c4cf6295ba47375c392b0c8c4298fc7a9534b8375d56125616e5a773/configs/aws-load-balancer-operator/catalog.json, this is the list of images that should be available in the destination registry:

  • "registry.redhat.io/albo/aws-load-balancer-controller-rhel8@sha256:537fc6c0219e98795bc9560869487bc1605a2556f2a06a9702d81c7fbea35132"
  • "registry.redhat.io/albo/aws-load-balancer-operator-bundle@sha256:e4799ae4d44aae350cf3307a23d3957fb68003a64dbae5e29be801a993a90f69"
  • "registry.redhat.io/albo/aws-load-balancer-rhel8-operator@sha256:b13db5fb28d1282bc53f73baeae75ab54854b41b0091be32431af35fb51950a0"
  • "registry.redhat.io/openshift4/ose-kube-rbac-proxy@sha256:1dddb0988d1612c996707d43eb839bc49fc7e7554afaf085436eeddb37a12438"

for each image, perform a curl against the destination registry to verify that the image was copied, and that a tag corresponding to the digest given in the list above exists. Example:

curl http://localhost:5000/v2/m2m/albo/aws-load-balancer-controller-rhel8/tags/list | grep 537fc6c0219e98795bc9560869487bc1605a2556f2a06a9702d81c7fbea35132

Do the same for the 3scale operator.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 5, 2024

@sherine-k: This pull request references CLID-35 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.17" instead.

In response to this:

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Expected Outcome

Please describe the outcome expected from the tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 5, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
@sherine-k sherine-k force-pushed the CLID-35 branch 4 times, most recently from 82d7699 to 480a94b Compare April 8, 2024 13:55
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2024

@sherine-k: This pull request references CLID-35 which is a valid jira issue.

In response to this:

Description

Implements part of S4 from operator filtering by direct selection of bundles .
This allows customers to explicitly point out the operator bundles for mirroring.
This helps in situations (especially future ones) where the customer has established the shortest path of upgrade for an operator in a tool external to oc-mirror, and would like to mirror only these bundle versions.

Fixes # CLID-35

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Using the following ImageSetConfig, perform a mirrorToDisk + diskToMirror.

kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v1alpha2
mirror:
 operators:
 - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.14
   packages:
   - name: aws-load-balancer-operator
     # channels:
     # - name: stable-4.13
     bundles:
     - name: aws-load-balancer-operator.v1.1.0
   - name: 3scale-operator
     bundles:
     - name: 3scale-operator.v0.10.0-mas

Expected Outcome

Both M2D and D2M operators should succeed.
From the content of working-dir/hold-operator/redhat-operator-index/856c0280c4cf6295ba47375c392b0c8c4298fc7a9534b8375d56125616e5a773/configs/aws-load-balancer-operator/catalog.json, this is the list of images that should be available in the destination registry:

  • "registry.redhat.io/albo/aws-load-balancer-controller-rhel8@sha256:537fc6c0219e98795bc9560869487bc1605a2556f2a06a9702d81c7fbea35132"
  • "registry.redhat.io/albo/aws-load-balancer-operator-bundle@sha256:e4799ae4d44aae350cf3307a23d3957fb68003a64dbae5e29be801a993a90f69"
  • "registry.redhat.io/albo/aws-load-balancer-rhel8-operator@sha256:b13db5fb28d1282bc53f73baeae75ab54854b41b0091be32431af35fb51950a0"
  • "registry.redhat.io/openshift4/ose-kube-rbac-proxy@sha256:1dddb0988d1612c996707d43eb839bc49fc7e7554afaf085436eeddb37a12438"

for each image, perform a curl against the destination registry to verify that the image was copied, and that a tag corresponding to the digest given in the list above exists. Example:

curl http://localhost:5000/v2/m2m/albo/aws-load-balancer-controller-rhel8/tags/list | grep 537fc6c0219e98795bc9560869487bc1605a2556f2a06a9702d81c7fbea35132

Do the same for the 3scale operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2024

@sherine-k: This pull request references CLID-35 which is a valid jira issue.

In response to this:

Description

Implements part of S4 from operator filtering by direct selection of bundles .
This allows customers to explicitly point out the operator bundles for mirroring.
This helps in situations (especially future ones) where the customer has established the shortest path of upgrade for an operator in a tool external to oc-mirror, and would like to mirror only these bundle versions.

Fixes # CLID-35

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Using the following ImageSetConfig, perform a mirrorToDisk + diskToMirror.

kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v1alpha2
mirror:
 operators:
 - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.14
   packages:
   - name: aws-load-balancer-operator
     # channels:
     # - name: stable-4.13
     bundles:
     - name: aws-load-balancer-operator.v1.1.0
   - name: 3scale-operator
     bundles:
     - name: 3scale-operator.v0.10.0-mas

Expected Outcome

Both M2D and D2M operators should succeed.
From the content of working-dir/hold-operator/redhat-operator-index/856c0280c4cf6295ba47375c392b0c8c4298fc7a9534b8375d56125616e5a773/configs/aws-load-balancer-operator/catalog.json, this is the list of images that should be available in the destination registry:

  • "registry.redhat.io/albo/aws-load-balancer-controller-rhel8@sha256:537fc6c0219e98795bc9560869487bc1605a2556f2a06a9702d81c7fbea35132"
  • "registry.redhat.io/albo/aws-load-balancer-operator-bundle@sha256:e4799ae4d44aae350cf3307a23d3957fb68003a64dbae5e29be801a993a90f69"
  • "registry.redhat.io/albo/aws-load-balancer-rhel8-operator@sha256:b13db5fb28d1282bc53f73baeae75ab54854b41b0091be32431af35fb51950a0"
  • "registry.redhat.io/openshift4/ose-kube-rbac-proxy@sha256:1dddb0988d1612c996707d43eb839bc49fc7e7554afaf085436eeddb37a12438"

for each image, perform a curl against the destination registry to verify that the image was copied, and that a tag corresponding to the digest given in the list above exists. Example:

curl http://localhost:5000/v2/m2m/albo/aws-load-balancer-controller-rhel8/tags/list | grep 537fc6c0219e98795bc9560869487bc1605a2556f2a06a9702d81c7fbea35132

Do the same for the 3scale operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lmzuccarelli
Copy link
Contributor

lmzuccarelli commented Apr 9, 2024

Verified locally
Using m2d and d2m - against remote registry and catalog-viewer-tool

FYI I used the catalog viewer tool to check the related images

Screenshot from 2024-04-09 11-53-01

@lmzuccarelli
Copy link
Contributor

@aguidirh - I'll wait for you to chime in before adding labels

v2/pkg/manifest/oci-manifest.go Show resolved Hide resolved
v2/pkg/manifest/oci-manifest.go Outdated Show resolved Hide resolved
Copy link
Contributor

@aguidirh aguidirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sherine-k,

This one is going to help our customers a lot, thanks!

Nit: suggested only small changes.

Copy link
Contributor

@aguidirh aguidirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job here.

As soon as PR #812 get merged I will add lgtm here.

Thanks.

}

relatedImages := make(map[string][]v1alpha3.RelatedImage)
var filteredBundles []string
defaultChannel := operatorConfig.Packages[operatorName].DefaultChannel

if len(iscOperator.Channels) > 0 {
switch {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing to switch statement here, it is easier to understand now.

Copy link

openshift-ci bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aguidirh, sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aguidirh
Copy link
Contributor

aguidirh commented Apr 17, 2024

Using this ImageSetConfiguration:

kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v1alpha2
mirror:
  operators:
  - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.14
    packages:
    - name: aws-load-balancer-operator
      bundles:
      - name: aws-load-balancer-operator.v1.1.0
      - name: aws-load-balancer-operator.v1.1.1
      - name: aws-load-balancer-operator.v0.2.0
    - name: 3scale-operator
      bundles:
      - name: 3scale-operator.v0.10.0-mas

I did mirrorToDisk, diskToMirror and checked if the related images for each bundle were in the target registry.

Test Results: SUCCESS (all required blobs in the target registry for all bundles in the ImageSetConfiguration)

aws-load-balancer-operator.v1.1.0

albo/aws-load-balancer-controller-rhel8@sha256:537fc6c0219e98795bc9560869487bc1605a2556f2a06a9702d81c7fbea35132
albo/aws-load-balancer-operator-bundle@sha256:e4799ae4d44aae350cf3307a23d3957fb68003a64dbae5e29be801a993a90f69
albo/aws-load-balancer-rhel8-operator@sha256:b13db5fb28d1282bc53f73baeae75ab54854b41b0091be32431af35fb51950a0
openshift4/ose-kube-rbac-proxy@sha256:1dddb0988d1612c996707d43eb839bc49fc7e7554afaf085436eeddb37a12438

aws-load-balancer-operator.v1.1.1
albo/aws-load-balancer-controller-rhel8@sha256:2e0b9332a44d8d9c23e19c7accab0813a651f39210257820db508cac28876595
albo/aws-load-balancer-operator-bundle@sha256:01f2ca529d2486f113bcefc9fedce6a6fd07bcb48aaf534394b5b04c353f8853
albo/aws-load-balancer-rhel8-operator@sha256:16e9ffed36107527a37713ac5bd34a7bc20f042269a81077429fb5884914c4d0
openshift4/ose-kube-rbac-proxy@sha256:f11f71448986aa17abec9caadb568a6cc34ef1a7898e6dc20bc6a512830ba476

aws-load-balancer-operator.v0.2.0
albo/aws-load-balancer-controller-rhel8@sha256:cfd210a2cb705156883fda126d052e05eb84345cc27ba04688067f8ed9a802ea
albo/aws-load-balancer-operator-bundle@sha256:3939323bc858e2a71b9ef0f858c5020ffd501e664a3652bd0be5f17176eb63f5
albo/aws-load-balancer-rhel8-operator@sha256:ab38b37c14f7f0897e09a18eca4a232a6c102b76e9283e401baed832852290b5
openshift4/ose-kube-rbac-proxy@sha256:e3dad360d0351237a16593ca0862652809c41a2127c2f98b9e0a559568efbd10

3scale-operator.v0.10.0-mas
3scale-mas/3scale-operator-bundle@sha256:21f2fe5fe1148b0883574f10176dea2485b2367afcdf11b71d3919c66a783ccd
3scale-mas/3scale-rhel7-operator@sha256:92a55183409d1dd263efb3e724d89998c9a2a39c00ae35d39d350409d4ed4662
3scale-mas/apicast-gateway-rhel8@sha256:df0d4958733702adbea1d361c6b39103e34ee4b270ea04488f275ea3ed578ec6
3scale-mas/backend-rhel8@sha256:f1112cda1ac57d06e544071cbb8b7d02fe3aa8e3dca55ab79d938f48d7e7bcdb
3scale-mas/memcached-rhel7@sha256:e61ce6aa5c639b4307b7cab9376910674d2f0881b3bd9c11b50ad1040e33c2b2
3scale-mas/system-rhel7@sha256:f8484f65bb0f790778dff3ab37fb0433e27ba59d702cf98ad31fa22688b5538e
3scale-mas/zync-rhel8@sha256:08346b23fd19a4ea9b3684daaf03a10b1daea0406d216977181a5a45ac4b97f7 
openshift4/ose-cli@sha256:4cf84063f78f81cb95ab27c73fc44160ff5d2267136408b4dbdd183b272be0b5
rhel8/mysql-80@sha256:462212ef1fc1a8564c10b4f0651de7ca0ae56581b50ac59e7182bceedcafb3e7
rhscl/postgresql-10-rhel7@sha256:9e5c33ab4fde807d1cb357493ea5ff831dbf0fa0a39df6f14a6c7e22be052723
rhscl/redis-5-rhel7@sha256:91781cf512d695339f5a92da8bfae40b42a5585d3b5627d30e6fea08afc932a4

curl http://localhost:6000/v2/albo/aws-load-balancer-controller-rhel8/tags/list | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   261  100   261    0     0  83439      0 --:--:-- --:--:-- --:--:-- 87000
{
  "name": "albo/aws-load-balancer-controller-rhel8",
  "tags": [
    "2e0b9332a44d8d9c23e19c7accab0813a651f39210257820db508cac28876595",
    "537fc6c0219e98795bc9560869487bc1605a2556f2a06a9702d81c7fbea35132",
    "cfd210a2cb705156883fda126d052e05eb84345cc27ba04688067f8ed9a802ea"
  ]
}

curl http://localhost:6000/v2/albo/aws-load-balancer-operator-bundle/tags/list | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   260  100   260    0     0   112k      0 --:--:-- --:--:-- --:--:--  126k
{
  "name": "albo/aws-load-balancer-operator-bundle",
  "tags": [
    "e4799ae4d44aae350cf3307a23d3957fb68003a64dbae5e29be801a993a90f69",
    "01f2ca529d2486f113bcefc9fedce6a6fd07bcb48aaf534394b5b04c353f8853",
    "3939323bc858e2a71b9ef0f858c5020ffd501e664a3652bd0be5f17176eb63f5"
  ]
}

curl http://localhost:6000/v2/albo/aws-load-balancer-rhel8-operator/tags/list | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   259  100   259    0     0  96569      0 --:--:-- --:--:-- --:--:--  126k
{
  "name": "albo/aws-load-balancer-rhel8-operator",
  "tags": [
    "16e9ffed36107527a37713ac5bd34a7bc20f042269a81077429fb5884914c4d0",
    "b13db5fb28d1282bc53f73baeae75ab54854b41b0091be32431af35fb51950a0",
    "ab38b37c14f7f0897e09a18eca4a232a6c102b76e9283e401baed832852290b5"
  ]
}

curl http://localhost:6000/v2/openshift4/ose-kube-rbac-proxy/tags/list | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   252  100   252    0     0   113k      0 --:--:-- --:--:-- --:--:--  123k
{
  "name": "openshift4/ose-kube-rbac-proxy",
  "tags": [
    "1dddb0988d1612c996707d43eb839bc49fc7e7554afaf085436eeddb37a12438",
    "e3dad360d0351237a16593ca0862652809c41a2127c2f98b9e0a559568efbd10",
    "f11f71448986aa17abec9caadb568a6cc34ef1a7898e6dc20bc6a512830ba476"
  ]
}

curl http://localhost:6000/v2/3scale-mas/3scale-operator-bundle/tags/list | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   121  100   121    0     0  53210      0 --:--:-- --:--:-- --:--:-- 60500
{
  "name": "3scale-mas/3scale-operator-bundle",
  "tags": [
    "21f2fe5fe1148b0883574f10176dea2485b2367afcdf11b71d3919c66a783ccd"
  ]
}

url http://localhost:6000/v2/3scale-mas/3scale-rhel7-operator/tags/list | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   120  100   120    0     0  51238      0 --:--:-- --:--:-- --:--:-- 60000
{
  "name": "3scale-mas/3scale-rhel7-operator",
  "tags": [
    "92a55183409d1dd263efb3e724d89998c9a2a39c00ae35d39d350409d4ed4662"
  ]
}

curl http://localhost:6000/v2/3scale-mas/apicast-gateway-rhel8/tags/list | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   120  100   120    0     0  39946      0 --:--:-- --:--:-- --:--:-- 60000
{
  "name": "3scale-mas/apicast-gateway-rhel8",
  "tags": [
    "df0d4958733702adbea1d361c6b39103e34ee4b270ea04488f275ea3ed578ec6"
  ]
}

curl http://localhost:6000/v2/3scale-mas/backend-rhel8/tags/list | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   112  100   112    0     0  45658      0 --:--:-- --:--:-- --:--:-- 56000
{
  "name": "3scale-mas/backend-rhel8",
  "tags": [
    "f1112cda1ac57d06e544071cbb8b7d02fe3aa8e3dca55ab79d938f48d7e7bcdb"
  ]
}

curl http://localhost:6000/v2/3scale-mas/memcached-rhel7/tags/list | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   114  100   114    0     0  35547      0 --:--:-- --:--:-- --:--:-- 38000
{
  "name": "3scale-mas/memcached-rhel7",
  "tags": [
    "e61ce6aa5c639b4307b7cab9376910674d2f0881b3bd9c11b50ad1040e33c2b2"
  ]
}

curl http://localhost:6000/v2/3scale-mas/system-rhel7/tags/list | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   111  100   111    0     0  19747      0 --:--:-- --:--:-- --:--:-- 22200
{
  "name": "3scale-mas/system-rhel7",
  "tags": [
    "f8484f65bb0f790778dff3ab37fb0433e27ba59d702cf98ad31fa22688b5538e"
  ]
}

curl http://localhost:6000/v2/3scale-mas/zync-rhel8/tags/list | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   109  100   109    0     0  44237      0 --:--:-- --:--:-- --:--:-- 54500
{
  "name": "3scale-mas/zync-rhel8",
  "tags": [
    "08346b23fd19a4ea9b3684daaf03a10b1daea0406d216977181a5a45ac4b97f7"
  ]
}

curl http://localhost:6000/v2/openshift4/ose-cli/tags/list | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   106  100   106    0     0  54950      0 --:--:-- --:--:-- --:--:--  103k
{
  "name": "openshift4/ose-cli",
  "tags": [
    "4cf84063f78f81cb95ab27c73fc44160ff5d2267136408b4dbdd183b272be0b5"
  ]
}

curl http://localhost:6000/v2/rhel8/mysql-80/tags/list | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   102  100   102    0     0  45842      0 --:--:-- --:--:-- --:--:-- 51000
{
  "name": "rhel8/mysql-80",
  "tags": [
    "462212ef1fc1a8564c10b4f0651de7ca0ae56581b50ac59e7182bceedcafb3e7"
  ]
}

curl http://localhost:6000/v2/rhscl/postgresql-10-rhel7/tags/list | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   113  100   113    0     0  49066      0 --:--:-- --:--:-- --:--:-- 56500
{
  "name": "rhscl/postgresql-10-rhel7",
  "tags": [
    "9e5c33ab4fde807d1cb357493ea5ff831dbf0fa0a39df6f14a6c7e22be052723"
  ]
}

curl http://localhost:6000/v2/rhscl/redis-5-rhel7/tags/list | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   107  100   107    0     0  37876      0 --:--:-- --:--:-- --:--:-- 53500
{
  "name": "rhscl/redis-5-rhel7",
  "tags": [
    "91781cf512d695339f5a92da8bfae40b42a5585d3b5627d30e6fea08afc932a4"
  ]
}

Copy link

openshift-ci bot commented Apr 18, 2024

@sherine-k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aguidirh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9ac063b into openshift:main Apr 18, 2024
5 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build oc-mirror-plugin-container-v4.16.0-202404181209.p0.g9ac063b.assembly.stream.el9 for distgit oc-mirror-plugin.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants