-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLID-101: Fix graph image mirroring after TLS verification enabling #840
Conversation
@sherine-k: This pull request references CLID-101 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@sherine-k: This pull request references CLID-101 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@sherine-k: This pull request references CLID-101 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@sherine-k: This pull request references CLID-101 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@sherine-k: This pull request references CLID-101 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Fix generation of upgradeService.yaml for MirrorToMirror use case We also fix the way we count errors during the batch phase, by creating error counters for release, operator and additional images.
@sherine-k: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
done pre-merge test for mirror2disk+disk2mirror and mirror2mirror, the |
/label qe-approved |
@sherine-k: This pull request references CLID-101 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sherine-k.
Amazing work here fixing the TLS and making the log to show the errors when it happened.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aguidirh, sherine-k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/reopen |
@sherine-k: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
GetReleaseReferenceImages
which was adding minVersion and maxVersion for releases). This made the executor fail whileGetRelease
to prepare for UpdateService.yaml generation. The modified filter did not match the one saved previously by the collectorGetReleaseReferenceImages
, instead of using the original one.Example of what is displayed in logs in case of errors during mirroring:
Fixes # CLID-101
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Successfully perform MirrorToDisk, DiskToMirror and MirrorToMirror with the following imageSetConfiguration:
Expected Outcome
Please describe the outcome expected from the tests