OCPBUGS-31858:CLID-97: Provide a way to skip failing images

[sherine-k]

Description

This PR provides a way to skip mirroring of images by skipping any images listed in the ImageSetConfig under blockedImages.

Fixes #OCPBUGS-31858

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Using the following imagesetconfig, mirroring should succeed in spite of the non-existing second additional image:

apiVersion: mirror.openshift.io/v2alpha1
kind: ImageSetConfiguration
mirror:
  additionalImages:
    - name: registry.redhat.io/ubi8/ubi:latest
    - name: registry.redhat.io/ubi8/ubi:fake
  blockedImages:
    - name: registry.redhat.io/ubi8/ubi:fake

Expected Outcome

Unit tests pass

[openshift-ci-robot]

@sherine-k: This pull request references Jira Issue OCPBUGS-31858, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # OCPBUGS-31858

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Expected Outcome

Please describe the outcome expected from the tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sherine-k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sherine-k]

/jira refresh

[openshift-ci-robot]

@sherine-k: This pull request references Jira Issue OCPBUGS-31858, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @kasturinarra

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@sherine-k: This pull request references Jira Issue OCPBUGS-31858, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @kasturinarra

In response to this:

Description

This PR provides a way to skip mirroring of images by skipping any images listed in the ImageSetConfig under blockedImages.
This PR also activates the following containers/image flags in order to help reduce errors during mirroring.

• --retry-times: the number of times to possibly retry. default is 2.
• --retry-delay: delay between 2 retries. Default 1s
• --image-timeout : Timeout for mirroring an image. Defaults to 10mn
• --max-parallel-downloads : the maximum layers to pull at the same time. Applies to a single copy operation.. Default to 6

Fixes #OCPBUGS-31858

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Using the following imagesetconfig, mirroring should succeed in spite of the non-existing second additional image:

apiVersion: mirror.openshift.io/v2alpha1
kind: ImageSetConfiguration
mirror:
 additionalImages:
   - name: registry.redhat.io/ubi8/ubi:latest
   - name: registry.redhat.io/ubi8/ubi:fake
 blockedImages:
   - name: registry.redhat.io/ubi8/ubi:fake

Expected Outcome

Unit tests pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[kasturinarra]

/label qe-approved

[openshift-ci]

@sherine-k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[lmzuccarelli]

/lgtm

[lmzuccarelli]

/label acknowledge-critical-fixes-only

[openshift-ci-robot]

@sherine-k: Jira Issue OCPBUGS-31858: All pull requests linked via external trackers have merged:

• openshift/oc-mirror#854

Jira Issue OCPBUGS-31858 has been moved to the MODIFIED state.

In response to this:

Description

This PR provides a way to skip mirroring of images by skipping any images listed in the ImageSetConfig under blockedImages.

Fixes #OCPBUGS-31858

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Using the following imagesetconfig, mirroring should succeed in spite of the non-existing second additional image:

apiVersion: mirror.openshift.io/v2alpha1
kind: ImageSetConfiguration
mirror:
 additionalImages:
   - name: registry.redhat.io/ubi8/ubi:latest
   - name: registry.redhat.io/ubi8/ubi:fake
 blockedImages:
   - name: registry.redhat.io/ubi8/ubi:fake

Expected Outcome

Unit tests pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-05-17-180525