OCPBUGS-33580: Fix shortestPath returning 3 times the same imageSet

[sherine-k]

Description

When selecting the release nodes that correspond to the filtering, we were using a slice. duplicates nodes lead to mirroring the release content more than once.
The fix consists of using a map in order to reduce the quantity of images.
PS: this is a practice that we should consider more overall for all collectors in the future, as some images (kube-rbac-proxy for one) is used in multiple components and operators. WDYT?

Fixes #OCPBUGS-33580

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

mirroring the following imagesetconfig with or without shortestPath: true should lead to the same number of mirrored images.

kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v2alpha1
archiveSize: 8
mirror:
  platform:
    channels:
    - name: stable-4.15                                             
      type: ocp
      minVersion: '4.15.11'
      maxVersion: '4.15.11'
      shortestPath: true

Expected Outcome

Success

[openshift-ci-robot]

@sherine-k: This pull request references Jira Issue OCPBUGS-33580, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Description

When selecting the release nodes that correspond to the filtering, we were using a slice. duplicates nodes lead to mirroring the release content more than once.
The fix consists of using a map in order to reduce the quantity of images.
PS: this is a practice that we should consider more overall for all collectors in the future, as some images (kube-rbac-proxy for one) is used in multiple components and operators. WDYT?

Fixes #OCPBUGS-33580

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

mirroring the following imagesetconfig with or without shortestPath: true should lead to the same number of mirrored images.

kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v2alpha1
archiveSize: 8
mirror:
 platform:
   channels:
   - name: stable-4.15                                             
     type: ocp
     minVersion: '4.15.11'
     maxVersion: '4.15.11'
     shortestPath: true

Expected Outcome

Success

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sherine-k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lmzuccarelli]

/lgtm

[lmzuccarelli]

/hold

[zhouying7780]

/label qe-approved

[openshift-ci-robot]

@sherine-k: This pull request references Jira Issue OCPBUGS-33580, which is invalid:

• expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Description

When selecting the release nodes that correspond to the filtering, we were using a slice. duplicates nodes lead to mirroring the release content more than once.
The fix consists of using a map in order to reduce the quantity of images.
PS: this is a practice that we should consider more overall for all collectors in the future, as some images (kube-rbac-proxy for one) is used in multiple components and operators. WDYT?

Fixes #OCPBUGS-33580

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

mirroring the following imagesetconfig with or without shortestPath: true should lead to the same number of mirrored images.

kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v2alpha1
archiveSize: 8
mirror:
 platform:
   channels:
   - name: stable-4.15                                             
     type: ocp
     minVersion: '4.15.11'
     maxVersion: '4.15.11'
     shortestPath: true

Expected Outcome

Success

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lmzuccarelli]

/jira refresh

[openshift-ci-robot]

@lmzuccarelli: This pull request references Jira Issue OCPBUGS-33580, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lmzuccarelli]

/unhold

[lmzuccarelli]

/retest

[openshift-ci-robot]

@sherine-k: Jira Issue OCPBUGS-33580: All pull requests linked via external trackers have merged:

• openshift/oc-mirror#856

Jira Issue OCPBUGS-33580 has been moved to the MODIFIED state.

In response to this:

Description

When selecting the release nodes that correspond to the filtering, we were using a slice. duplicates nodes lead to mirroring the release content more than once.
The fix consists of using a map in order to reduce the quantity of images.
PS: this is a practice that we should consider more overall for all collectors in the future, as some images (kube-rbac-proxy for one) is used in multiple components and operators. WDYT?

Fixes #OCPBUGS-33580

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

mirroring the following imagesetconfig with or without shortestPath: true should lead to the same number of mirrored images.

kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v2alpha1
archiveSize: 8
mirror:
 platform:
   channels:
   - name: stable-4.15                                             
     type: ocp
     minVersion: '4.15.11'
     maxVersion: '4.15.11'
     shortestPath: true

Expected Outcome

Success

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@sherine-k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build oc-mirror-plugin-container-v4.17.0-202405301013.p0.ge640610.assembly.stream.el9 for distgit oc-mirror-plugin.
All builds following this will include this PR.