Add warning when mirroring SchemaVersion:1 images that digests are no…

…t preserved.

Also, update TODOs with functions handling schema conversions to drop support for Schema v1 in future release.

pkg/cli/image/manifest/manifest.go

@@ -428,7 +428,7 @@ func ManifestsFromList(ctx context.Context, srcDigest digest.Digest, srcManifest
 	}
 }
 
-// TDOO: remove when quay.io switches to v2 schema
+// TODO: Remove support for v2 schema in 4.9
 func PutManifestInCompatibleSchema(
 	ctx context.Context,
 	srcManifest distribution.Manifest,
@@ -538,7 +538,7 @@ func convertToSchema2(ctx context.Context, blobs distribution.BlobService, srcMa
 	return b.Build(ctx)
 }
 
-// TDOO: remove when quay.io switches to v2 schema
+// TODO: Remove support for v2 schema in 4.9
 func convertToSchema1(ctx context.Context, blobs distribution.BlobService, configJSON []byte, schema2Manifest *schema2.DeserializedManifest, ref reference.Named) (distribution.Manifest, error) {
 	if configJSON == nil {
 		targetDescriptor := schema2Manifest.Target()
@@ -573,7 +573,7 @@ var (
 	privateKey     libtrust.PrivateKey
 )
 
-// TDOO: remove when quay.io switches to v2 schema
+// TODO: Remove support for v2 schema in 4.9
 func loadPrivateKey() (libtrust.PrivateKey, error) {
 	privateKeyLock.Lock()
 	defer privateKeyLock.Unlock()

pkg/cli/image/mirror/mirror.go

@@ -339,7 +339,7 @@ func (o *MirrorImageOptions) Run() error {
 								srcDigest := digest
 								tags := op.digestsToTags[srcDigest].List()
 								w.Parallel(func() {
-									if errs := copyManifestToTags(ctx, ref, srcDigest, tags, op, o.Out); len(errs) > 0 {
+									if errs := copyManifestToTags(ctx, ref, srcDigest, tags, op, o.Out, o.ErrOut); len(errs) > 0 {
 										phase.ExecutionFailure(errs...)
 									}
 								})
@@ -355,7 +355,7 @@ func (o *MirrorImageOptions) Run() error {
 
 								srcDigest := godigest.Digest(digest)
 								w.Parallel(func() {
-									if err := copyManifest(ctx, ref, srcDigest, op, o.Out); err != nil {
+									if err := copyManifest(ctx, ref, srcDigest, op, o.Out, o.ErrOut); err != nil {
 										phase.ExecutionFailure(err)
 									}
 								})
@@ -720,6 +720,7 @@ func copyManifestToTags(
 	tags []string,
 	plan *repositoryManifestPlan,
 	out io.Writer,
+	errOut io.Writer,
 ) []error {
 	var errs []error
 	srcManifest, ok := plan.parent.parent.parent.GetManifest(srcDigest)
@@ -735,6 +736,9 @@ func copyManifestToTags(
 		for _, desc := range srcManifest.References() {
 			plan.parent.parent.AssociateBlob(desc.Digest, plan.parent.name)
 		}
+		if srcDigest != toDigest {
+			fmt.Fprintf(errOut, "warning: Digests are not preserved with schema version 1 images. Support for schema version 1 images will be removed in a future release.\n")
+		}
 		plan.parent.parent.SavedManifest(srcDigest, toDigest)
 		fmt.Fprintf(out, "%s %s:%s\n", toDigest, plan.toRef, tag)
 	}
@@ -747,6 +751,7 @@ func copyManifest(
 	srcDigest godigest.Digest,
 	plan *repositoryManifestPlan,
 	out io.Writer,
+	errOut io.Writer,
 ) error {
 	srcManifest, ok := plan.parent.parent.parent.GetManifest(srcDigest)
 	if !ok {
@@ -759,6 +764,9 @@ func copyManifest(
 	for _, desc := range srcManifest.References() {
 		plan.parent.parent.AssociateBlob(desc.Digest, plan.parent.name)
 	}
+	if srcDigest != toDigest {
+		fmt.Fprintf(errOut, "warning: Digests are not preserved with schema version 1 images. Support for schema version 1 images will be removed in a future release.\n")
+	}
 	plan.parent.parent.SavedManifest(srcDigest, toDigest)
 	fmt.Fprintf(out, "%s %s\n", toDigest, plan.toRef)
 	return nil

pkg/cli/image/mirror/plan.go

@@ -341,7 +341,7 @@ func (p *registryPlan) SavedManifest(srcDigest, dstDigest godigest.Digest) {
 	}
 	p.lock.Lock()
 	defer p.lock.Unlock()
-	klog.V(4).Infof("Associated digest %s with converted digest %s", srcDigest, dstDigest)
+	klog.V(2).Infof("Associated digest: %s, Converted digest: %s", srcDigest, dstDigest)
 	p.manifestConversions[srcDigest] = dstDigest
 }