Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow users to specify max ICSP size
Problem: It is possible for the `oc adm catalog mirror` command to generate ICSPs that are greater than 1000000 bytes in size. ICSPs that exceed 1000000 bytes are likely to fail when applied to the cluster if the objec already existed in an early state as the `kubectl.kubernetes.io/last-applied-configuration` annotation will likely exceed the 2000000 etcd resource byte limit. Solution: Introduce a the max-icsp-size flag to the `oc adm catalog mirror` command, allowing users to specify the maximum byte size of ICSP files generated by the command. If an ICSP would exceed this limit, create and begin writting mirrors to a new ICSP. The default ICSP limit is 1000000 bytes.
- Loading branch information
Showing
2 changed files
with
278 additions
and
88 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.