Bug 2086519: pkg/cli/debug: suggest pod security labels on violations #1155
Conversation
|
/assign @soltysh |
| kcmdutil.CheckErr(o.RunDebug()) | ||
|
|
||
| cmdErr := o.RunDebug() | ||
| if o.IsNode { |
There was a problem hiding this comment.
this really only applies to debugging node targets? @soltysh ?
There was a problem hiding this comment.
nevermind, this is clarified in #1123 (comment). however we should add a small godoc to say why.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s-urbaniak, soltysh, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
stlaz
changed the title
openshift-ci
bot
added
bugzilla/severity-urgent
|
@stlaz: This pull request references Bugzilla bug 2086519, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stlaz: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
|
/retest-required |
|
@stlaz: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2086519 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR improves and obsoletes #1123