Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use correct namespace with sample templates #1272

Merged
merged 1 commit into from Oct 24, 2022
Merged

use correct namespace with sample templates #1272

merged 1 commit into from Oct 24, 2022

Conversation

sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Oct 21, 2022 •
edited

Bumping openshift-apiserver brings with it stricter validation of namespace (obj vs. request).

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

2 similar comments
@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@ardaguclu
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2022
@sanchezl
Copy link
Contributor Author

/retest

@tkashem
Copy link

tkashem commented Oct 24, 2022

/approve

@sanchezl
Copy link
Contributor Author

/assign @coreydaley

@mfojtik
Copy link
Member

mfojtik commented Oct 24, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, mfojtik, sanchezl, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@openshift-merge-robot openshift-merge-robot merged commit 494f678 into openshift:master Oct 24, 2022
@ardaguclu ardaguclu mentioned this pull request Jan 4, 2023
Merged
@dgrisonnet
Copy link
Member

/cherrypick release-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 28, 2023
Closed
@openshift-cherrypick-robot
Copy link

@dgrisonnet: new pull request created: #1605

In response to this:

/cherrypick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgrisonnet dgrisonnet mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreydaley coreydaley Awaiting requested review from coreydaley

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

@coreydaley coreydaley

@ardaguclu ardaguclu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sanchezl @ardaguclu @tkashem @mfojtik @dgrisonnet @openshift-cherrypick-robot @coreydaley @openshift-merge-robot