pkg/cli/admin/release/info: Render multi-arch release information #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
wking
force-pushed
the
multi-arch-release-arch-rendering
branch
from
eac5120
to
aa87d25
Compare
|
/cc |
petr-muller
approved these changes
Nov 22, 2022
openshift-ci
bot
added
the
do-not-merge/hold
wking
force-pushed
the
multi-arch-release-arch-rendering
branch
from
aa87d25
to
ae46096
Compare
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
Comparing release text for various arch-specific shards of the multi-arch 4.12.0-rc.0 release: $ for B in arm64 ppc64le s390x; do diff -u <(curl -s https://mirror.openshift.com/pub/openshift-v4/multi/clients/ocp/4.12.0-rc.0/amd64/release.txt) <(curl -s "https://mirror.openshift.com/pub/openshift-v4/multi/clients/ocp/4.12.0-rc.0/${B}/release.txt"); done --- /dev/fd/63 2022-11-16 14:57:24.849975880 -0800 +++ /dev/fd/62 2022-11-16 14:57:24.854975880 -0800 @@ -13,7 +13,7 @@ Name: 4.12.0-rc.0 Digest: sha256:7ac78aaca993bf307010e8e92642da2bc28e275fbac241b42f24be46153f12d1 Created: 2022-11-10T19:12:09Z -OS/Arch: linux/amd64 +OS/Arch: linux/arm64 Manifests: 643 Metadata files: 1 --- /dev/fd/63 2022-11-16 14:57:26.195975808 -0800 +++ /dev/fd/62 2022-11-16 14:57:26.195975808 -0800 @@ -13,7 +13,7 @@ Name: 4.12.0-rc.0 Digest: sha256:7ac78aaca993bf307010e8e92642da2bc28e275fbac241b42f24be46153f12d1 Created: 2022-11-10T19:12:09Z -OS/Arch: linux/amd64 +OS/Arch: linux/ppc64le Manifests: 643 Metadata files: 1 --- /dev/fd/63 2022-11-16 14:57:26.821975774 -0800 +++ /dev/fd/62 2022-11-16 14:57:26.824975774 -0800 @@ -13,7 +13,7 @@ Name: 4.12.0-rc.0 Digest: sha256:7ac78aaca993bf307010e8e92642da2bc28e275fbac241b42f24be46153f12d1 Created: 2022-11-10T19:12:09Z -OS/Arch: linux/amd64 +OS/Arch: linux/s390x Manifests: 643 Metadata files: 1 With this change, those OS/Arch properties will be rendered like: OS/Arch: multi (linux/amd64) and similar, to make it more obvious that the release payload as a whole is multi-architecture.
wking
force-pushed
the
multi-arch-release-arch-rendering
branch
from
ae46096
to
2ea70a4
Compare
wking
commented
Nov 24, 2022
| @@ -736,15 +736,23 @@ func (i *ReleaseInfo) PreferredName() string { | |||
| } | |||
|
|
|||
| func (i *ReleaseInfo) Platform() string { | |||
| os := i.Config.OS | |||
| if len(os) > 0 { | |||
There was a problem hiding this comment.
This wasn't causing trouble before, because describeReleaseInfo wasn't using this Platform method, but the > was a bug, and I'm fixing it to ==.
|
@wking: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing release text for various arch-specific shards of the multi-arch 4.12.0-rc.0 release:
With this change, those OS/Arch properties will be rendered like:
and similar, to make it more obvious that the release payload as a whole is multi-architecture.