Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: IR-301: generates ImageStreamTags with import-mode when using oc new-build #1352

Closed
wants to merge 2 commits into from
Closed

WIP: IR-301: generates ImageStreamTags with import-mode when using oc new-build #1352

wants to merge 2 commits into from

Conversation

prb112
Copy link
Contributor

@prb112 prb112 commented Feb 22, 2023 •
edited by openshift-ci bot

  • support Legacy and PreserveOriginal import-mode with oc new-build
  • add a guard to protect a panic when no DockerConfig exists

Depends on IR-300

@prb112
IR-300: enhances oc new-app with ImageRegistry ImportMode
ffd23e6 
- add new flag --import-mode=Legacy or --import-mode=PreserveOriginal
- the default is Legacy

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112
IR-301: generates ImageStreamTags with import-mode when using oc new-…
4190c17 
…build

- support Legacy and PreserveOriginal import-mode with oc new-build
- add a guard to protect a panic when no DockerConfig exists

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 22, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 22, 2023 •
edited by openshift-ci bot

@prb112: This pull request references IR-301 which is a valid jira issue.

In response to this:

  • support Legacy and PreserveOriginal import-mode with oc new-build
  • add a guard to protect a panic when no DockerConfig exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 22, 2023 •
edited by openshift-ci bot

@prb112: This pull request references IR-301 which is a valid jira issue.

In response to this:

  • support Legacy and PreserveOriginal import-mode with oc new-build
  • add a guard to protect a panic when no DockerConfig exists

Depends on IR-300

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 22, 2023 •
edited by openshift-ci bot

@prb112: This pull request references IR-301 which is a valid jira issue.

In response to this:

  • support Legacy and PreserveOriginal import-mode with oc new-build
  • add a guard to protect a panic when no DockerConfig exists

Depends on IR-300

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prb112
Once this PR has been reviewed and has the lgtm label, please assign coreydaley for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@prb112 prb112 closed this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prb112 @openshift-ci-robot