OCPBUGS-11632: Skip invalid events yamls and continue #1429
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@ardaguclu: This pull request references Jira Issue OCPBUGS-11632, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ingvagabund could you PTAL?. Thanks. |
|
/cc @kasturinarra |
|
@ardaguclu: This pull request references Jira Issue OCPBUGS-11632, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
| @@ -191,7 +191,8 @@ func getAllEventsRecursive(rootDir string) (*corev1.EventList, error) { | |||
| } | |||
| events, err := readEvents(eventBytes) | |||
| if err != nil { | |||
| return fmt.Errorf("failed to read event err: %v", err) | |||
| klog.Warningf("skipping %s, failed to read event err: %v", string(eventBytes), err) | |||
There was a problem hiding this comment.
getAllEventsRecursive should be renamed then to reflect the fact the function will do best-effort instead. E.g. getEventsRecursive + mentioning the best-effort intention in the function description.
Still better to get at least something rather then nothing.
There was a problem hiding this comment.
Thanks for review @ingvagabund. You are right, I renamed function.
|
Unit test failures should be fixed by #1430 |
|
/lgtm With the error there's no webpage generated so we are not making the situation worst. Actually, the webpage gets generated with at least a subset of the original events. |
|
Known flaky test( |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
|
@ardaguclu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@ardaguclu: Jira Issue OCPBUGS-11632: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-11632 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Although it is rare, if
events.yamlfile is invalid,oc adm must-gatherandoc adm inspectcommands return non zero exit code because they fail when generatingevent-filter.html. Since we don't have control on events, we can warn user and continue process instead returning error.