Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add command for regenerating OCP leaf certs #1443

Merged
merged 2 commits into from Jun 12, 2023
Merged

add command for regenerating OCP leaf certs #1443

merged 2 commits into from Jun 12, 2023

Conversation

stlaz
Copy link
Member

@stlaz stlaz commented Jun 8, 2023

builds on top of #1439

/assign @deads2k

@openshift-ci openshift-ci bot requested review from ardaguclu and soltysh June 8, 2023 11:07
@stlaz
Copy link
Member Author

stlaz commented Jun 8, 2023

we may want to extend this for the Prometheus/OpenShift-authenticator client certs

@deads2k
Copy link
Contributor

deads2k commented Jun 9, 2023

https://github.com/openshift/oc/pull/1443/files#r1224178638 is blocking. lgtm after

@stlaz stlaz force-pushed the deads_cert_regen branch 3 times, most recently from 64d5145 to b9de2f2 Compare June 9, 2023 11:29
@deads2k
Copy link
Contributor

deads2k commented Jun 9, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 9, 2023
@stlaz stlaz mentioned this pull request Jun 9, 2023
Merged
3 tasks
@deads2k deads2k added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 9, 2023
@deads2k
Copy link
Contributor

deads2k commented Jun 9, 2023

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@deads2k
Copy link
Contributor

deads2k commented Jun 12, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4e13676 and 2 for PR HEAD 32d7dfc in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d01359d and 1 for PR HEAD 32d7dfc in total

@deads2k
Copy link
Contributor

deads2k commented Jun 12, 2023

/refresh

@deads2k
Copy link
Contributor

deads2k commented Jun 12, 2023

/override ci/prow/e2e-agnostic-ovn-cmd

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-agnostic-ovn-cmd

In response to this:

/override ci/prow/e2e-agnostic-ovn-cmd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

@stlaz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ad8fc4d into openshift:master Jun 12, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stlaz @deads2k @openshift-ci-robot @openshift-merge-robot