New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bring some cert rotation helpers back into 4.12 [fix unit-tests] #1478
bring some cert rotation helpers back into 4.12 [fix unit-tests] #1478
Conversation
…particular datetime
… the fake client In later versions, the fake client simply handles the server-side apply patches just as it would handle the strategic merge type ones. Build a Fake wrapper that does the same.
/retest-required |
@stlaz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I'll take it. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4.13 merged, merging 4.12 |
55f2e3c
into
openshift:release-4.12
This PR attempts to fix the unit test issues due to unsupported server-side applies in the fake client from #1475 (comment)
/assign @deads2k